mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: David Howells <dhowells@redhat.com>, Petr Mladek <pmladek@suse.com>
Cc: linux-kernel@vger.kernel.org, jack@suse.cz, will.deacon@arm.com,
	rostedt@goodmis.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] printk: Don't discard earlier unprinted messages to make space
Date: Thu, 22 Oct 2015 14:23:34 +0100	[thread overview]
Message-ID: <1445520214.4113.63.camel@infradead.org> (raw)
In-Reply-To: <483.1445519966@warthog.procyon.org.uk>

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

On Thu, 2015-10-22 at 14:19 +0100, David Howells wrote:
> Petr Mladek <pmladek@suse.com> wrote:
> 
> > I would expect that the first few messages are printed to the console
> > before the buffer is wrapped. IMHO, in many cases, you are interested
> > into the final messages that describe why the system went down.
> 
> The last message might tell you that the machine panicked because the NMI
> handler triggered due to a spinlocked section taking too long or something.
> This doesn't help if the oops that caused the spinlock to remain held or
> whatever gets discarded from the buffer due to several intervening complaints
> that result secondarily from the initial oops.
> 
> > If there is no time to print them, you want to have them in the crash dump
> > (ring buffer) at least.
> 
> But not at the expense of discarding the first oops report.  *That* one is the
> most important.
> 
> Perhaps things could be arranged such that messages *can* be discarded from
> the front of the buffer *provided* they are not oops messages.

Of course, all this is a symptom of the fact that printk is now lossy.
If you had an option to make it reliable again, you wouldn't need to
argue over *which* messages to lose.

-- 
dwmw2


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]

  reply	other threads:[~2015-10-22 13:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 10:16 David Howells
2015-10-22 10:28 ` David Woodhouse
2015-10-22 12:18   ` Jan Kara
2015-10-22 12:36     ` David Woodhouse
2015-10-22 12:30 ` Petr Mladek
2015-10-22 13:19 ` David Howells
2015-10-22 13:23   ` David Woodhouse [this message]
2015-10-23  8:49   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445520214.4113.63.camel@infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome