[PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

[PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

[savoca]

Adding support for device 0x07e8 (SP4 Type Cover)

Signed-off-by: savoca <alex.deddo@daqri.com>
---
 drivers/hid/hid-core.c          | 2 ++
 drivers/hid/hid-ids.h           | 1 +
 drivers/hid/hid-microsoft.c     | 2 ++
 drivers/hid/usbhid/hid-quirks.c | 1 +
 4 files changed, 6 insertions(+)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 70a11ac..d54dde5 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -727,6 +727,7 @@ static void hid_scan_collection(struct hid_parser *parser, unsigned type)
 	    (hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 ||
 	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP ||
 	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 ||
+	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4 ||
 	     hid->product == USB_DEVICE_ID_MS_POWER_COVER) &&
 	    hid->group == HID_GROUP_MULTITOUCH)
 		hid->group = HID_GROUP_GENERIC;
@@ -1930,6 +1931,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY, USB_DEVICE_ID_GENIUS_KB29E) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index f769208..cebeb0a 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -681,6 +681,7 @@
 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3    0x07dc
 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd
 #define USB_DEVICE_ID_MS_TYPE_COVER_3    0x07de
+#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4    0x07e8
 #define USB_DEVICE_ID_MS_POWER_COVER     0x07da
 
 #define USB_VENDOR_ID_MOJO		0x8282
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index 9aa3515..b663abf 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -282,6 +282,8 @@ static const struct hid_device_id ms_devices[] = {
 		.driver_data = MS_HIDINPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3),
 		.driver_data = MS_HIDINPUT },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4),
+		.driver_data = MS_HIDINPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER),
 		.driver_data = MS_HIDINPUT },
 
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 1dff8f0..954aedd 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -93,6 +93,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS },
+	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, HID_QUIRK_NO_INIT_REPORTS },
-- 
1.9.1

Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

[Jiri Kosina]

On Tue, 27 Oct 2015, savoca wrote:

> Adding support for device 0x07e8 (SP4 Type Cover)
> 
> Signed-off-by: savoca <alex.deddo@daqri.com>

Thanks for the patch.

The authorship and signoffs should same real names though. Could you 
please resend with that fixed?

-- 
Jiri Kosina
SUSE Labs

Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

[Andy Shevchenko]

On Fri, Oct 30, 2015 at 3:53 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Tue, 27 Oct 2015, savoca wrote:
>
>> Adding support for device 0x07e8 (SP4 Type Cover)
>>
>> Signed-off-by: savoca <alex.deddo@daqri.com>
>
> Thanks for the patch.
>
> The authorship and signoffs should same real names though. Could you
> please resend with that fixed?
>

Have you guys noticed the patch [1] to support Surface Book along with
Surface Pro 3?

[1] https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

[Andy Shevchenko]

Summon author, Kenny, of the mentioned patch.

On Fri, Oct 30, 2015 at 7:49 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Oct 30, 2015 at 3:53 PM, Jiri Kosina <jikos@kernel.org> wrote:
>> On Tue, 27 Oct 2015, savoca wrote:
>>
>>> Adding support for device 0x07e8 (SP4 Type Cover)
>>>
>>> Signed-off-by: savoca <alex.deddo@daqri.com>
>>
>> Thanks for the patch.
>>
>> The authorship and signoffs should same real names though. Could you
>> please resend with that fixed?
>>
>
> Have you guys noticed the patch [1] to support Surface Book along with
> Surface Pro 3?
>
> [1] https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

[Andy Shevchenko]

On Fri, Oct 30, 2015 at 9:21 PM, Kenny Speer <kenny.speer@gmail.com> wrote:
> Hi All, what information would you like?

Just found many patches are flying around to support MS Surface 3 /
Pro 3 / Pro 4 / Book.
https://groups.google.com/forum/?hl=en#!topic/linux-surface/VlE9JGvxEyg

I'm actually interested in Book support. So, I think someone has to
sort this out and prepare series based on what is found.

>
> BTW, here is the same patch for the 4.3rc7 kernel which already contains the
> surface button driver.
>
> https://github.com/neoreeps/surface-pro-3/blob/master/4.3_surface.patch
>
> ~kenny
>
> On Fri, Oct 30, 2015 at 11:39 AM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>>
>> Summon author, Kenny, of the mentioned patch.
>>
>> On Fri, Oct 30, 2015 at 7:49 PM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>> > On Fri, Oct 30, 2015 at 3:53 PM, Jiri Kosina <jikos@kernel.org> wrote:
>> >> On Tue, 27 Oct 2015, savoca wrote:
>> >>
>> >>> Adding support for device 0x07e8 (SP4 Type Cover)
>> >>>
>> >>> Signed-off-by: savoca <alex.deddo@daqri.com>
>> >>
>> >> Thanks for the patch.
>> >>
>> >> The authorship and signoffs should same real names though. Could you
>> >> please resend with that fixed?
>> >>
>> >
>> > Have you guys noticed the patch [1] to support Surface Book along with
>> > Surface Pro 3?
>> >
>> > [1]
>> > https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch
>> >
>> > --
>> > With Best Regards,
>> > Andy Shevchenko
>>
>>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>
>



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

[Jiri Kosina]

On Fri, 30 Oct 2015, Andy Shevchenko wrote:

> >> Adding support for device 0x07e8 (SP4 Type Cover)
> >>
> >> Signed-off-by: savoca <alex.deddo@daqri.com>
> >
> > Thanks for the patch.
> >
> > The authorship and signoffs should same real names though. Could you
> > please resend with that fixed?
> >
> 
> Have you guys noticed the patch [1] to support Surface Book along with
> Surface Pro 3?

Not really. A quick scan through my mailbox tells me that it has actually 
never submitted to me for inclusion into the kernel.

> [1] https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch

-- 
Jiri Kosina
SUSE Labs

[PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover

[savoca]

From: Alex Deddo <alex.deddo@daqri.com>

Adding support for device 0x07e8 (SP4 Type Cover)

Signed-off-by: Alex Deddo <alex.deddo@daqri.com>
---
 drivers/hid/hid-core.c          | 2 ++
 drivers/hid/hid-ids.h           | 1 +
 drivers/hid/hid-microsoft.c     | 2 ++
 drivers/hid/usbhid/hid-quirks.c | 1 +
 4 files changed, 6 insertions(+)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 70a11ac..d54dde5 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -727,6 +727,7 @@ static void hid_scan_collection(struct hid_parser *parser, unsigned type)
 	    (hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 ||
 	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP ||
 	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 ||
+	     hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4 ||
 	     hid->product == USB_DEVICE_ID_MS_POWER_COVER) &&
 	    hid->group == HID_GROUP_MULTITOUCH)
 		hid->group = HID_GROUP_GENERIC;
@@ -1930,6 +1931,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY, USB_DEVICE_ID_GENIUS_KB29E) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index f769208..cebeb0a 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -681,6 +681,7 @@
 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3    0x07dc
 #define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd
 #define USB_DEVICE_ID_MS_TYPE_COVER_3    0x07de
+#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4    0x07e8
 #define USB_DEVICE_ID_MS_POWER_COVER     0x07da
 
 #define USB_VENDOR_ID_MOJO		0x8282
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index 9aa3515..b663abf 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -282,6 +282,8 @@ static const struct hid_device_id ms_devices[] = {
 		.driver_data = MS_HIDINPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3),
 		.driver_data = MS_HIDINPUT },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4),
+		.driver_data = MS_HIDINPUT },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER),
 		.driver_data = MS_HIDINPUT },
 
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 1dff8f0..954aedd 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -93,6 +93,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS },
+	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, HID_QUIRK_NO_INIT_REPORTS },
-- 
1.9.1