mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: fernando@oss.ntt.co.jp
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>,
	linux-kernel@vger.kernel.org, vojtech@suse.cz,
	akpm@linux-foundation.org
Subject: Re: [PATCH] fix return value of i8042_aux_test_irq
Date: Thu, 26 Jul 2007 23:49:56 +0900 (JST)	[thread overview]
Message-ID: <1446.172.50.1.13.1185461396.squirrel@172.19.0.2> (raw)
In-Reply-To: <20070726151042.0ae34e0e@the-village.bc.nu>

On Thu, July 26, 2007 11:10 pm, Alan Cox wrote:
>> The handler does handle the interrupt - both status and data registers
>> are read so from the keyboard controller point of view the interrupt
>> has been handled even if we happen to discard the data. As far as I
>> know IRQ12 is never shared by BIOS... Vojtech, do you remember why we
>> request IRQ12 with IRQF_SHARED?
>
> A small number of boxes do share IRQ12 and it was switched to shared for
> them.
If that is the case interrupt handlers should be able to determine whether
a certain interrupt comes from their respective devices, and return
IRQ_HANDLED or IRQ_NONE accordingly. Returning IRQ_HANDLED unconditionally
when IRQF_SHARED is set seems strange. Is this behavior intended?


  reply	other threads:[~2007-07-26 14:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-26  8:04 Fernando Luis Vázquez Cao
2007-07-26 13:54 ` Dmitry Torokhov
2007-07-26 14:10   ` Alan Cox
2007-07-26 14:49     ` fernando [this message]
2007-07-26 15:29       ` Alan Cox
2007-07-26 15:57         ` fernando
2007-07-29  5:27           ` Dmitry Torokhov
2007-07-26 14:38   ` Vojtech Pavlik
2007-07-26 14:39   ` fernando
2007-07-26 15:51   ` fernando

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446.172.50.1.13.1185461396.squirrel@172.19.0.2 \
    --to=fernando@oss.ntt.co.jp \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®