From: fernando@oss.ntt.co.jp
To: "Alan Cox" <alan@lxorguk.ukuu.org.uk>
Cc: fernando@oss.ntt.co.jp,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, vojtech@suse.cz,
akpm@linux-foundation.org
Subject: Re: [PATCH] fix return value of i8042_aux_test_irq
Date: Fri, 27 Jul 2007 00:57:09 +0900 (JST) [thread overview]
Message-ID: <2090.172.50.1.13.1185465429.squirrel@172.19.0.2> (raw)
In-Reply-To: <20070726162913.2dc9a9b2@the-village.bc.nu>
On Fri, July 27, 2007 12:29 am, Alan Cox wrote:
>> > A small number of boxes do share IRQ12 and it was switched to shared
>> for
>> > them.
>> If that is the case interrupt handlers should be able to determine
>> whether
>> a certain interrupt comes from their respective devices, and return
>> IRQ_HANDLED or IRQ_NONE accordingly. Returning IRQ_HANDLED
>> unconditionally
>> when IRQF_SHARED is set seems strange. Is this behavior intended?
>
> Sometimes you simple can't tell and in those cases you have no choice.
As I mentioned in a previous email, i8042_interrupt considers that it
should not handle an interrupt when there is no data to read and,
accordingly, it returns IRQ_NONE in such cases. I was just wondering if we
could follow the same approach to make i8042_aux_test_irq more
IRQF_SHARED-friendly.
- Fernando
next prev parent reply other threads:[~2007-07-26 15:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-26 8:04 Fernando Luis Vázquez Cao
2007-07-26 13:54 ` Dmitry Torokhov
2007-07-26 14:10 ` Alan Cox
2007-07-26 14:49 ` fernando
2007-07-26 15:29 ` Alan Cox
2007-07-26 15:57 ` fernando [this message]
2007-07-29 5:27 ` Dmitry Torokhov
2007-07-26 14:38 ` Vojtech Pavlik
2007-07-26 14:39 ` fernando
2007-07-26 15:51 ` fernando
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2090.172.50.1.13.1185465429.squirrel@172.19.0.2 \
--to=fernando@oss.ntt.co.jp \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®