* [PATCH 0/8] Staging: rtl8192u: ieee80211: checkpatch cleanups @ 2015-10-28 12:46 Kurt Kanzenbach 2015-10-28 12:46 ` [PATCH 1/8] Staging: rtl8192u: ieee80211: fixed open brace positions Kurt Kanzenbach 0 siblings, 1 reply; 3+ messages in thread From: Kurt Kanzenbach @ 2015-10-28 12:46 UTC (permalink / raw) To: gregkh Cc: dilekuzulmez, arnd, navyasri.tech, paul.gortmaker, devel, linux-kernel, Kurt Kanzenbach This patch series corrects most checkpatch.pl errors and some warnings in the ieee80211_crypt_tkip.c file. Kurt Kanzenbach (8): Staging: rtl8192u: ieee80211: fixed open brace positions Staging: rtl8192u: ieee80211: fixed position of else statements Staging: rtl8192u: ieee80211: added missing space around '=' Staging: rtl8192u: ieee80211: added missing spaces after if Staging: rtl8192u: ieee80211: corrected indent Staging: rtl8192u: ieee80211: corrected block comments Staging: rtl8192u: ieee80211: removed unnecessary braces Staging: rtl8192u: ieee80211: added missing blank lines .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 76 ++++++++++++---------- 1 file changed, 41 insertions(+), 35 deletions(-) -- 2.4.10 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/8] Staging: rtl8192u: ieee80211: fixed open brace positions 2015-10-28 12:46 [PATCH 0/8] Staging: rtl8192u: ieee80211: checkpatch cleanups Kurt Kanzenbach @ 2015-10-28 12:46 ` Kurt Kanzenbach 0 siblings, 0 replies; 3+ messages in thread From: Kurt Kanzenbach @ 2015-10-28 12:46 UTC (permalink / raw) To: gregkh Cc: dilekuzulmez, arnd, navyasri.tech, paul.gortmaker, devel, linux-kernel, Kurt Kanzenbach This patch fixes the following checkpatch error: - ERROR: that open brace { should be on the previous line Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de> --- .../staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c index 1f80c52..dd058b6 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c @@ -185,8 +185,7 @@ static inline u16 Mk16_le(u16 *v) } -static const u16 Sbox[256] = -{ +static const u16 Sbox[256] = { 0xC6A5, 0xF884, 0xEE99, 0xF68D, 0xFF0D, 0xD6BD, 0xDEB1, 0x9154, 0x6050, 0x0203, 0xCEA9, 0x567D, 0xE719, 0xB562, 0x4DE6, 0xEC9A, 0x8F45, 0x1F9D, 0x8940, 0xFA87, 0xEF15, 0xB2EB, 0x8EC9, 0xFB0B, @@ -320,8 +319,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) hdr = (struct rtl_80211_hdr_4addr *) skb->data; - if (!tcb_desc->bHwSec) - { + if (!tcb_desc->bHwSec) { if (!tkey->tx_phase1_done) { tkip_mixing_phase1(tkey->tx_ttak, tkey->key, hdr->addr2, tkey->tx_iv32); @@ -338,14 +336,12 @@ static int ieee80211_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) memmove(pos, pos + 8, hdr_len); pos += hdr_len; - if (tcb_desc->bHwSec) - { + if (tcb_desc->bHwSec) { *pos++ = Hi8(tkey->tx_iv16); *pos++ = (Hi8(tkey->tx_iv16) | 0x20) & 0x7F; *pos++ = Lo8(tkey->tx_iv16); } - else - { + else { *pos++ = rc4key[0]; *pos++ = rc4key[1]; *pos++ = rc4key[2]; @@ -357,8 +353,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) *pos++ = (tkey->tx_iv32 >> 16) & 0xff; *pos++ = (tkey->tx_iv32 >> 24) & 0xff; - if (!tcb_desc->bHwSec) - { + if (!tcb_desc->bHwSec) { icv = skb_put(skb, 4); crc = ~crc32_le(~0, pos, len); icv[0] = crc; @@ -429,8 +424,7 @@ static int ieee80211_tkip_decrypt(struct sk_buff *skb, int hdr_len, void *priv) iv32 = pos[4] | (pos[5] << 8) | (pos[6] << 16) | (pos[7] << 24); pos += 8; - if (!tcb_desc->bHwSec) - { + if (!tcb_desc->bHwSec) { if (iv32 < tkey->rx_iv32 || (iv32 == tkey->rx_iv32 && iv16 <= tkey->rx_iv16)) { if (net_ratelimit()) { -- 2.4.10 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 0/8] Staging: rtl8192u: ieee80211: checkpatch cleanups @ 2015-10-28 13:01 Kurt Kanzenbach 2015-10-28 13:01 ` [PATCH 1/8] Staging: rtl8192u: ieee80211: fixed open brace positions Kurt Kanzenbach 0 siblings, 1 reply; 3+ messages in thread From: Kurt Kanzenbach @ 2015-10-28 13:01 UTC (permalink / raw) To: gregkh Cc: dilekuzulmez, arnd, navyasri.tech, paul.gortmaker, devel, linux-kernel, Kurt Kanzenbach This patch series corrects most checkpatch.pl errors and some warnings in the ieee80211_crypt_tkip.c file. Kurt Kanzenbach (8): Staging: rtl8192u: ieee80211: fixed open brace positions Staging: rtl8192u: ieee80211: fixed position of else statements Staging: rtl8192u: ieee80211: added missing space around '=' Staging: rtl8192u: ieee80211: added missing spaces after if Staging: rtl8192u: ieee80211: corrected indent Staging: rtl8192u: ieee80211: corrected block comments Staging: rtl8192u: ieee80211: removed unnecessary braces Staging: rtl8192u: ieee80211: added missing blank lines .../rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 76 ++++++++++++---------- 1 file changed, 41 insertions(+), 35 deletions(-) -- 2.4.10 ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/8] Staging: rtl8192u: ieee80211: fixed open brace positions 2015-10-28 13:01 [PATCH 0/8] Staging: rtl8192u: ieee80211: checkpatch cleanups Kurt Kanzenbach @ 2015-10-28 13:01 ` Kurt Kanzenbach 0 siblings, 0 replies; 3+ messages in thread From: Kurt Kanzenbach @ 2015-10-28 13:01 UTC (permalink / raw) To: gregkh Cc: dilekuzulmez, arnd, navyasri.tech, paul.gortmaker, devel, linux-kernel, Kurt Kanzenbach This patch fixes the following checkpatch error: - ERROR: that open brace { should be on the previous line Signed-off-by: Kurt Kanzenbach <kurt@kmk-computers.de> --- .../staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c index 1f80c52..dd058b6 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c @@ -185,8 +185,7 @@ static inline u16 Mk16_le(u16 *v) } -static const u16 Sbox[256] = -{ +static const u16 Sbox[256] = { 0xC6A5, 0xF884, 0xEE99, 0xF68D, 0xFF0D, 0xD6BD, 0xDEB1, 0x9154, 0x6050, 0x0203, 0xCEA9, 0x567D, 0xE719, 0xB562, 0x4DE6, 0xEC9A, 0x8F45, 0x1F9D, 0x8940, 0xFA87, 0xEF15, 0xB2EB, 0x8EC9, 0xFB0B, @@ -320,8 +319,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) hdr = (struct rtl_80211_hdr_4addr *) skb->data; - if (!tcb_desc->bHwSec) - { + if (!tcb_desc->bHwSec) { if (!tkey->tx_phase1_done) { tkip_mixing_phase1(tkey->tx_ttak, tkey->key, hdr->addr2, tkey->tx_iv32); @@ -338,14 +336,12 @@ static int ieee80211_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) memmove(pos, pos + 8, hdr_len); pos += hdr_len; - if (tcb_desc->bHwSec) - { + if (tcb_desc->bHwSec) { *pos++ = Hi8(tkey->tx_iv16); *pos++ = (Hi8(tkey->tx_iv16) | 0x20) & 0x7F; *pos++ = Lo8(tkey->tx_iv16); } - else - { + else { *pos++ = rc4key[0]; *pos++ = rc4key[1]; *pos++ = rc4key[2]; @@ -357,8 +353,7 @@ static int ieee80211_tkip_encrypt(struct sk_buff *skb, int hdr_len, void *priv) *pos++ = (tkey->tx_iv32 >> 16) & 0xff; *pos++ = (tkey->tx_iv32 >> 24) & 0xff; - if (!tcb_desc->bHwSec) - { + if (!tcb_desc->bHwSec) { icv = skb_put(skb, 4); crc = ~crc32_le(~0, pos, len); icv[0] = crc; @@ -429,8 +424,7 @@ static int ieee80211_tkip_decrypt(struct sk_buff *skb, int hdr_len, void *priv) iv32 = pos[4] | (pos[5] << 8) | (pos[6] << 16) | (pos[7] << 24); pos += 8; - if (!tcb_desc->bHwSec) - { + if (!tcb_desc->bHwSec) { if (iv32 < tkey->rx_iv32 || (iv32 == tkey->rx_iv32 && iv16 <= tkey->rx_iv16)) { if (net_ratelimit()) { -- 2.4.10 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-28 13:08 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2015-10-28 12:46 [PATCH 0/8] Staging: rtl8192u: ieee80211: checkpatch cleanups Kurt Kanzenbach 2015-10-28 12:46 ` [PATCH 1/8] Staging: rtl8192u: ieee80211: fixed open brace positions Kurt Kanzenbach 2015-10-28 13:01 [PATCH 0/8] Staging: rtl8192u: ieee80211: checkpatch cleanups Kurt Kanzenbach 2015-10-28 13:01 ` [PATCH 1/8] Staging: rtl8192u: ieee80211: fixed open brace positions Kurt Kanzenbach
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®