From: Joe Perches <joe@perches.com>
To: Bogicevic Sasa <brutallesale@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis
Date: Wed, 28 Oct 2015 11:23:51 -0700 [thread overview]
Message-ID: <1446056631.2757.143.camel@perches.com> (raw)
In-Reply-To: <1446056004-6092-1-git-send-email-brutallesale@gmail.com>
On Wed, 2015-10-28 at 19:13 +0100, Bogicevic Sasa wrote:
> This fixes all Alignment should match open parenthesis
> messages from checkpatch.pl
What you suggest is not at all generally accepted kernel style.
> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
[]
> @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type)
> return -ENOMEM;
> skb_reserve(skb_out, NET_IP_ALIGN);
>
> - memcpy(skb_put(skb_out, mac_header_len), mac_header_data,
> + memcpy(
> + skb_put(skb_out, mac_header_len), mac_header_data,
> mac_header_len);
What's desired here is:
memcpy(skb_put(skb_out, mac_header_len), mac_header_data,
mac_header_len);
Second line should be:
[tab][7 spaces]mac_header_len);
etc...
btw: Please run your _patches_ through checkpatch.pl, not just
use it to find style issues in files.
next prev parent reply other threads:[~2015-10-28 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 18:13 Bogicevic Sasa
2015-10-28 18:23 ` Joe Perches [this message]
2015-10-28 18:53 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446056631.2757.143.camel@perches.com \
--to=joe@perches.com \
--cc=brutallesale@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®