* [PATCH RESEND] fpga: socfpga: Fix check of return value of devm_request_irq
@ 2015-10-29 15:56 Moritz Fischer
0 siblings, 0 replies; only message in thread
From: Moritz Fischer @ 2015-10-29 15:56 UTC (permalink / raw)
To: atull; +Cc: linux-kernel, joshc, gregkh, Moritz Fischer
The return value should be checked for non-zero, instead
of checking it being IS_ERR_VALUE().
Acked-by: Alan Tull <atull@opensource.altera.com>
Reviewed-by: Josh Cartwright <joshc@eso.teric.us>
Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
---
drivers/fpga/socfpga.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c
index 706b80d..27d2ff2 100644
--- a/drivers/fpga/socfpga.c
+++ b/drivers/fpga/socfpga.c
@@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0,
dev_name(dev), priv);
- if (IS_ERR_VALUE(ret))
+ if (ret)
return ret;
return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager",
--
2.4.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-29 15:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-29 15:56 [PATCH RESEND] fpga: socfpga: Fix check of return value of devm_request_irq Moritz Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®