From: Philipp Zabel <p.zabel@pengutronix.de>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, puck.chen@aliyun.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk
Subject: Re: [PATCH V6 2/3] Add reset controller for hi6220 SoC platform.
Date: Thu, 29 Oct 2015 17:14:52 +0100 [thread overview]
Message-ID: <1446135292.3274.67.camel@pengutronix.de> (raw)
In-Reply-To: <1446123303-91956-2-git-send-email-puck.chen@hisilicon.com>
Am Donnerstag, den 29.10.2015, 20:55 +0800 schrieb Chen Feng:
> reset: add driver for hi6220 reset controller
Same comment as for patch 1, this should probably be the subject,
the commit message body was better in V4.
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
> ---
> drivers/reset/Kconfig | 1 +
> drivers/reset/Makefile | 1 +
> drivers/reset/hisilicon/Kconfig | 5 ++
> drivers/reset/hisilicon/Makefile | 1 +
> drivers/reset/hisilicon/hi6220_reset.c | 108 +++++++++++++++++++++++++
> include/dt-bindings/reset/hisi,hi6220-resets.h | 67 +++++++++++++++
Move the header file into patch 1, it is better to include this with the
binding documentation.
regards
Philipp
next prev parent reply other threads:[~2015-10-29 16:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-29 12:55 [PATCH V6 1/3] Add DT bindings documentation for hi6220 SoC reset controller Chen Feng
2015-10-29 12:55 ` [PATCH V6 2/3] Add reset controller for hi6220 SoC platform Chen Feng
2015-10-29 16:14 ` Philipp Zabel [this message]
2015-10-30 2:45 ` chenfeng
2015-10-29 12:55 ` [PATCH V6 3/3] Add reset-cell node for hi6220 reset controller Chen Feng
2015-10-29 16:14 ` [PATCH V6 1/3] Add DT bindings documentation for hi6220 SoC " Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446135292.3274.67.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=puck.chen@aliyun.com \
--cc=puck.chen@hisilicon.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®