From: Matt Fleming <matt@codeblueprint.co.uk>
To: Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: Toshi Kani <toshi.kani@hp.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Subject: [PATCH 3/6] x86/efi: Map RAM into the identity page table for mixed mode
Date: Thu, 12 Nov 2015 15:40:20 +0000 [thread overview]
Message-ID: <1447342823-3612-4-git-send-email-matt@codeblueprint.co.uk> (raw)
In-Reply-To: <1447342823-3612-1-git-send-email-matt@codeblueprint.co.uk>
We are relying on the pre-existing mappings in 'trampoline_pgd' when
accessing function arguments in the EFI mixed mode thunking code.
Instead let's map memory explicitly so that things will continue to
work when we move to a separate page table in the future.
Cc: Borislav Petkov <bp@alien8.de>
Cc: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
---
arch/x86/platform/efi/efi_64.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/arch/x86/platform/efi/efi_64.c b/arch/x86/platform/efi/efi_64.c
index c8b58ac47b77..634536034e32 100644
--- a/arch/x86/platform/efi/efi_64.c
+++ b/arch/x86/platform/efi/efi_64.c
@@ -144,6 +144,7 @@ void efi_sync_low_kernel_mappings(void)
int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages)
{
unsigned long pfn, text;
+ efi_memory_desc_t *md;
struct page *page;
unsigned npages;
pgd_t *pgd;
@@ -200,6 +201,25 @@ int __init efi_setup_page_tables(unsigned long pa_memmap, unsigned num_pages)
efi_scratch.phys_stack += PAGE_SIZE; /* stack grows down */
+ /*
+ * Map all of RAM so that we can access arguments in the 1:1
+ * mapping when making EFI runtime calls.
+ */
+ for_each_efi_memory_desc(&memmap, md) {
+ if (md->type != EFI_CONVENTIONAL_MEMORY &&
+ md->type != EFI_LOADER_DATA &&
+ md->type != EFI_LOADER_CODE)
+ continue;
+
+ pfn = md->phys_addr >> PAGE_SHIFT;
+ npages = md->num_pages;
+
+ if (kernel_map_pages_in_pgd(pgd, pfn, md->phys_addr, npages, 0)) {
+ pr_err("Failed to map 1:1 memory\n");
+ return 1;
+ }
+ }
+
return 0;
}
--
2.6.2
next prev parent reply other threads:[~2015-11-12 15:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 15:40 [GIT PULL 0/6] EFI page table isolation Matt Fleming
2015-11-12 15:40 ` [PATCH 1/6] x86/mm/pageattr: Ensure cpa->pfn only contains page frame numbers Matt Fleming
2015-11-12 18:47 ` Borislav Petkov
2015-11-12 15:40 ` [PATCH 2/6] x86/mm/pageattr: Do not strip pte flags from cpa->pfn Matt Fleming
2015-11-12 18:47 ` Borislav Petkov
2015-11-12 19:28 ` Matt Fleming
2015-11-12 15:40 ` Matt Fleming [this message]
2015-11-12 18:01 ` [PATCH 3/6] x86/efi: Map RAM into the identity page table for mixed mode Borislav Petkov
2015-11-12 19:45 ` Matt Fleming
2015-11-12 15:40 ` [PATCH 4/6] x86/efi: Hoist page table switching code into efi_call_virt() Matt Fleming
2015-11-12 18:44 ` Borislav Petkov
2015-11-12 20:01 ` Matt Fleming
2015-11-13 7:59 ` Borislav Petkov
2015-11-13 16:19 ` Matt Fleming
2015-11-12 18:47 ` Borislav Petkov
2015-11-12 20:15 ` Matt Fleming
2015-11-12 15:40 ` [PATCH 5/6] x86/efi: Build our own page table structures Matt Fleming
2015-11-12 18:38 ` Borislav Petkov
2015-11-12 21:38 ` Matt Fleming
2015-11-12 15:40 ` [PATCH 6/6] Documentation/x86: Update EFI memory region description Matt Fleming
2015-11-12 18:37 ` Borislav Petkov
2015-11-13 9:22 ` Ingo Molnar
2015-11-13 9:29 ` Matt Fleming
2015-11-13 16:42 ` Linus Torvalds
2015-11-13 22:22 ` Matt Fleming
2015-11-18 8:18 ` Ingo Molnar
2015-11-19 11:22 ` Matt Fleming
2015-11-23 13:33 [GIT PULL v3 0/6] EFI page table isolation Matt Fleming
2015-11-23 13:33 ` [PATCH 3/6] x86/efi: Map RAM into the identity page table for mixed mode Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447342823-3612-4-git-send-email-matt@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=toshi.kani@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome