* [PATCH] drivers:pci:hotplug Fix space prohibited after function name
@ 2015-11-15 12:37 Bogicevic Sasa
2015-11-15 17:07 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Bogicevic Sasa @ 2015-11-15 12:37 UTC (permalink / raw)
To: bhelgaas; +Cc: wangyijing, linux-pci, linux-kernel, Bogicevic Sasa
This fixes warning that a space is prohibited after function name
Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
---
drivers/pci/hotplug/pci_hotplug_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
index 2bac1b9..d379d49 100644
--- a/drivers/pci/hotplug/pci_hotplug_core.c
+++ b/drivers/pci/hotplug/pci_hotplug_core.c
@@ -226,7 +226,7 @@ static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf,
u32 test;
int retval = 0;
- ltest = simple_strtoul (buf, NULL, 10);
+ ltest = simple_strtoul(buf, NULL, 10);
test = (u32)(ltest & 0xffffffff);
dbg("test = %d\n", test);
--
2.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drivers:pci:hotplug Fix space prohibited after function name
2015-11-15 12:37 [PATCH] drivers:pci:hotplug Fix space prohibited after function name Bogicevic Sasa
@ 2015-11-15 17:07 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2015-11-15 17:07 UTC (permalink / raw)
To: Bogicevic Sasa; +Cc: Bjorn Helgaas, wangyijing, linux-pci, linux-kernel
On Sun, Nov 15, 2015 at 2:37 PM, Bogicevic Sasa <brutallesale@gmail.com> wrote:
> This fixes warning that a space is prohibited after function name
>
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
> drivers/pci/hotplug/pci_hotplug_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
> index 2bac1b9..d379d49 100644
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -226,7 +226,7 @@ static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf,
> u32 test;
> int retval = 0;
>
> - ltest = simple_strtoul (buf, NULL, 10);
> + ltest = simple_strtoul(buf, NULL, 10);
> test = (u32)(ltest & 0xffffffff);
Looks like all above could be replaced by
int retval;
retval = kstrtou32(… &test);
if (retval)
return retval;
> dbg("test = %d\n", test);
>
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-15 17:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-15 12:37 [PATCH] drivers:pci:hotplug Fix space prohibited after function name Bogicevic Sasa
2015-11-15 17:07 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®