[PATCH] drivers:pci:hotplug Fix simple_strtoul is obsolete, use kstrtoul instead

[PATCH] drivers:pci:hotplug Fix simple_strtoul is obsolete, use kstrtoul instead

[Bogicevic Sasa]

This fixes messages "simple_strtoul is obsolete, use kstrtoul instead"
from checkpatch.pl script

Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
---
 drivers/pci/hotplug/pci_hotplug_core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
index d379d49..a1160c8 100644
--- a/drivers/pci/hotplug/pci_hotplug_core.c
+++ b/drivers/pci/hotplug/pci_hotplug_core.c
@@ -103,7 +103,7 @@ static ssize_t power_write_file(struct pci_slot *pci_slot, const char *buf,
 	u8 power;
 	int retval = 0;
 
-	lpower = simple_strtoul(buf, NULL, 10);
+	lpower = kstrtoul(buf, NULL, 10);
 	power = (u8)(lpower & 0xff);
 	dbg("power = %d\n", power);
 
@@ -160,7 +160,7 @@ static ssize_t attention_write_file(struct pci_slot *pci_slot, const char *buf,
 	u8 attention;
 	int retval = 0;
 
-	lattention = simple_strtoul(buf, NULL, 10);
+	lattention = kstrtoul(buf, NULL, 10);
 	attention = (u8)(lattention & 0xff);
 	dbg(" - attention = %d\n", attention);
 
@@ -226,7 +226,7 @@ static ssize_t test_write_file(struct pci_slot *pci_slot, const char *buf,
 	u32 test;
 	int retval = 0;
 
-	ltest = simple_strtoul(buf, NULL, 10);
+	ltest = kstrtoul(buf, NULL, 10);
 	test = (u32)(ltest & 0xffffffff);
 	dbg("test = %d\n", test);
 
-- 
2.1.4

Re: [PATCH] drivers:pci:hotplug Fix simple_strtoul is obsolete, use kstrtoul instead

[Guenter Roeck]

On Sun, Nov 15, 2015 at 01:43:55PM +0100, Bogicevic Sasa wrote:
> This fixes messages "simple_strtoul is obsolete, use kstrtoul instead"
> from checkpatch.pl script
> 
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> ---
>  drivers/pci/hotplug/pci_hotplug_core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/hotplug/pci_hotplug_core.c b/drivers/pci/hotplug/pci_hotplug_core.c
> index d379d49..a1160c8 100644
> --- a/drivers/pci/hotplug/pci_hotplug_core.c
> +++ b/drivers/pci/hotplug/pci_hotplug_core.c
> @@ -103,7 +103,7 @@ static ssize_t power_write_file(struct pci_slot *pci_slot, const char *buf,
>  	u8 power;
>  	int retval = 0;
>  
> -	lpower = simple_strtoul(buf, NULL, 10);
> +	lpower = kstrtoul(buf, NULL, 10);

I take it you did not test this code, since it would probably result
in a crash. Does it even compile ?

Hint: When replacing one function call with another, it helps updating
the parameters.

Guenter