mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] crypto: sun4i-ss: add missing statesize
@ 2015-11-16  8:35 LABBE Corentin
  2015-11-16  8:35 ` LABBE Corentin
  0 siblings, 1 reply; 2+ messages in thread
From: LABBE Corentin @ 2015-11-16  8:35 UTC (permalink / raw)
  To: arno, axboe, boris.brezillon, clabbe.montjoie, cristian.stoica,
	dan.j.williams, davem, dmitry.torokhov, fabio.estevam, herbert,
	horia.geanta, jamie, linux-arm-kernel, steve.cornelius,
	thomas.petazzoni, vicki.milhoan
  Cc: linux-crypto, linux-kernel


Hello

The current sun4i-ss cannot be loaded with the error "Failed to load md5".
The following patch will fix that.

Changes since v1:
- Add the correct fixes tag.
- Add the correct #version comment for stable.
- Be more precise against the commit who made this change necessary.

Regards


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2] crypto: sun4i-ss: add missing statesize
  2015-11-16  8:35 [PATCH v2] crypto: sun4i-ss: add missing statesize LABBE Corentin
@ 2015-11-16  8:35 ` LABBE Corentin
  0 siblings, 0 replies; 2+ messages in thread
From: LABBE Corentin @ 2015-11-16  8:35 UTC (permalink / raw)
  To: clabbe.montjoie, davem, herbert, linux-arm-kernel, maxime.ripard, wens
  Cc: stable, linux-crypto, linux-kernel

sun4i-ss implementaton of md5/sha1 is via ahash algorithms.
Commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero")
made impossible to load them without giving statesize. This patch
specifiy statesize for sha1 and md5.

Fixes: 6298e948215f ("crypto: sunxi-ss - Add Allwinner Security System crypto accelerator")
Cc: <stable@vger.kernel.org> # v4.3+
Tested-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
 drivers/crypto/sunxi-ss/sun4i-ss-core.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-core.c b/drivers/crypto/sunxi-ss/sun4i-ss-core.c
index eab6fe2..107cd2a 100644
--- a/drivers/crypto/sunxi-ss/sun4i-ss-core.c
+++ b/drivers/crypto/sunxi-ss/sun4i-ss-core.c
@@ -39,6 +39,7 @@ static struct sun4i_ss_alg_template ss_algs[] = {
 		.import = sun4i_hash_import_md5,
 		.halg = {
 			.digestsize = MD5_DIGEST_SIZE,
+			.statesize = sizeof(struct md5_state),
 			.base = {
 				.cra_name = "md5",
 				.cra_driver_name = "md5-sun4i-ss",
@@ -66,6 +67,7 @@ static struct sun4i_ss_alg_template ss_algs[] = {
 		.import = sun4i_hash_import_sha1,
 		.halg = {
 			.digestsize = SHA1_DIGEST_SIZE,
+			.statesize = sizeof(struct sha1_state),
 			.base = {
 				.cra_name = "sha1",
 				.cra_driver_name = "sha1-sun4i-ss",
-- 
2.4.10


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-16  8:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-16  8:35 [PATCH v2] crypto: sun4i-ss: add missing statesize LABBE Corentin
2015-11-16  8:35 ` LABBE Corentin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®