mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: serge@hallyn.com
To: linux-kernel@vger.kernel.org
Cc: adityakali@google.com, tj@kernel.org, linux-api@vger.kernel.org,
	containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
	lxc-devel@lists.linuxcontainers.org, akpm@linux-foundation.org,
	ebiederm@xmission.com
Subject: [PATCH 4/8] cgroup: export cgroup_get() and cgroup_put()
Date: Mon, 16 Nov 2015 13:51:41 -0600	[thread overview]
Message-ID: <1447703505-29672-5-git-send-email-serge@hallyn.com> (raw)
In-Reply-To: <1447703505-29672-1-git-send-email-serge@hallyn.com>

From: Aditya Kali <adityakali@google.com>

move cgroup_get() and cgroup_put() into cgroup.h so that
they can be called from other places.

Signed-off-by: Aditya Kali <adityakali@google.com>
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
---
 include/linux/cgroup.h |   21 +++++++++++++++++++++
 kernel/cgroup.c        |   22 ----------------------
 2 files changed, 21 insertions(+), 22 deletions(-)

diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index 29f0b02..99096be 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -231,6 +231,27 @@ void css_task_iter_end(struct css_task_iter *it);
 #define css_for_each_descendant_post(pos, css)				\
 	for ((pos) = css_next_descendant_post(NULL, (css)); (pos);	\
 	     (pos) = css_next_descendant_post((pos), (css)))
+/* convenient tests for these bits */
+static inline bool cgroup_is_dead(const struct cgroup *cgrp)
+{
+	return !(cgrp->self.flags & CSS_ONLINE);
+}
+
+static inline void cgroup_get(struct cgroup *cgrp)
+{
+	WARN_ON_ONCE(cgroup_is_dead(cgrp));
+	css_get(&cgrp->self);
+}
+
+static inline bool cgroup_tryget(struct cgroup *cgrp)
+{
+	return css_tryget(&cgrp->self);
+}
+
+static inline void cgroup_put(struct cgroup *cgrp)
+{
+	css_put(&cgrp->self);
+}
 
 /**
  * cgroup_taskset_for_each - iterate cgroup_taskset
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index e29c346..e972259 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -417,28 +417,6 @@ out_unlock:
 	return css;
 }
 
-/* convenient tests for these bits */
-static inline bool cgroup_is_dead(const struct cgroup *cgrp)
-{
-	return !(cgrp->self.flags & CSS_ONLINE);
-}
-
-static void cgroup_get(struct cgroup *cgrp)
-{
-	WARN_ON_ONCE(cgroup_is_dead(cgrp));
-	css_get(&cgrp->self);
-}
-
-static bool cgroup_tryget(struct cgroup *cgrp)
-{
-	return css_tryget(&cgrp->self);
-}
-
-static void cgroup_put(struct cgroup *cgrp)
-{
-	css_put(&cgrp->self);
-}
-
 struct cgroup_subsys_state *of_css(struct kernfs_open_file *of)
 {
 	struct cgroup *cgrp = of->kn->parent->priv;
-- 
1.7.9.5


  parent reply	other threads:[~2015-11-16 19:52 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 19:51 CGroup Namespaces (v4) serge
2015-11-16 19:51 ` [PATCH 1/8] kernfs: Add API to generate relative kernfs path serge
2015-11-24 16:16   ` Tejun Heo
2015-11-24 16:17     ` Tejun Heo
2015-11-24 17:43       ` Serge E. Hallyn
2015-11-27  5:25     ` Serge E. Hallyn
2015-11-30 15:11       ` Tejun Heo
2015-11-30 18:37         ` Serge E. Hallyn
2015-11-30 22:53           ` Tejun Heo
2015-12-01  2:08             ` Serge E. Hallyn
2015-11-16 19:51 ` [PATCH 2/8] sched: new clone flag CLONE_NEWCGROUP for cgroup namespace serge
2015-11-16 19:51 ` [PATCH 3/8] cgroup: add function to get task's cgroup serge
2015-11-24 16:27   ` Tejun Heo
2015-11-24 16:54     ` Tejun Heo
2015-11-16 19:51 ` serge [this message]
2015-11-24 16:30   ` [PATCH 4/8] cgroup: export cgroup_get() and cgroup_put() Tejun Heo
2015-11-24 22:35     ` Serge E. Hallyn
2015-11-16 19:51 ` [PATCH 5/8] cgroup: introduce cgroup namespaces serge
2015-11-24 16:49   ` Tejun Heo
2015-11-16 19:51 ` [PATCH 6/8] cgroup: cgroup namespace setns support serge
2015-11-24 16:52   ` Tejun Heo
2015-11-16 19:51 ` [PATCH 7/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge
2015-11-24 17:16   ` Tejun Heo
2015-11-25  6:01     ` Serge E. Hallyn
2015-11-25 19:10       ` Tejun Heo
2015-11-25 19:55         ` Serge Hallyn
2015-11-25 19:57           ` Tejun Heo
2015-11-27  5:17     ` Serge E. Hallyn
2015-11-30 15:09       ` Tejun Heo
2015-12-01  4:07         ` Serge E. Hallyn
2015-12-01 16:46           ` Tejun Heo
2015-12-01 21:58             ` Serge E. Hallyn
2015-12-02 16:53               ` Tejun Heo
2015-12-02 16:56                 ` Serge E. Hallyn
2015-12-02 16:58                   ` Tejun Heo
2015-12-02 17:02                     ` Serge E. Hallyn
2015-12-02 17:05                       ` Tejun Heo
2015-12-03 22:47                         ` Serge E. Hallyn
2015-12-07 15:39                           ` Tejun Heo
2015-12-07 15:53                             ` Serge Hallyn
2015-11-16 19:51 ` [PATCH 8/8] cgroup: Add documentation for cgroup namespaces serge
2015-11-24 17:16   ` Tejun Heo
2015-11-16 20:41 ` CGroup Namespaces (v4) Richard Weinberger
2015-11-16 20:46   ` Serge E. Hallyn
2015-11-16 20:50     ` Richard Weinberger
2015-11-16 20:54       ` Serge E. Hallyn
2015-11-16 22:24         ` Eric W. Biederman
2015-11-16 22:37           ` Tejun Heo
2015-11-17  1:13           ` Serge E. Hallyn
2015-11-17  1:40             ` Serge E. Hallyn
2015-11-17  3:54               ` Serge E. Hallyn
2015-11-18  2:30           ` Serge E. Hallyn
2015-11-18  9:18             ` Eric W. Biederman
2015-11-18 15:43               ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447703505-29672-5-git-send-email-serge@hallyn.com \
    --to=serge@hallyn.com \
    --cc=adityakali@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lxc-devel@lists.linuxcontainers.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®