From: Philipp Zabel <p.zabel@pengutronix.de>
To: Chen Feng <puck.chen@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, puck.chen@aliyun.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org
Subject: Re: [PATCH V6 RESEND 2/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC
Date: Wed, 18 Nov 2015 18:27:55 +0100 [thread overview]
Message-ID: <1447867675.23650.0.camel@pengutronix.de> (raw)
In-Reply-To: <1446175164-116524-2-git-send-email-puck.chen@hisilicon.com>
Am Freitag, den 30.10.2015, 11:19 +0800 schrieb Chen Feng:
> Add reset driver for hi6220-hikey board,this driver supply deassert
> of IP on hi6220 SoC.
>
> Signed-off-by: Chen Feng <puck.chen@hisilicon.com>
[...]
> diff --git a/drivers/reset/hisilicon/Kconfig b/drivers/reset/hisilicon/Kconfig
> new file mode 100644
> index 0000000..26bf95a
> --- /dev/null
> +++ b/drivers/reset/hisilicon/Kconfig
> @@ -0,0 +1,5 @@
> +config COMMON_RESET_HI6220
> + tristate "Hi6220 Reset Driver"
> + depends on (ARCH_HISI && RESET_CONTROLLER)
> + help
> + Build the Hisilicon Hi6220 reset driver.
Why is this configurable? Can't you just drop the Kconfig and use ...
> diff --git a/drivers/reset/hisilicon/Makefile b/drivers/reset/hisilicon/Makefile
> new file mode 100644
> index 0000000..c932f86
> --- /dev/null
> +++ b/drivers/reset/hisilicon/Makefile
> @@ -0,0 +1 @@
> +obj-$(CONFIG_COMMON_RESET_HI6220) += hi6220_reset.o
... obj-$(CONFIG_ARCH_HISI) += hi6220_reset.o
here?
regards
Philipp
next prev parent reply other threads:[~2015-11-18 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 3:19 [PATCH V6 RESEND 1/3] reset: hisilicon: document hisi-hi6220 reset controllers bindings Chen Feng
2015-10-30 3:19 ` [PATCH V6 RESEND 2/3] reset: hi6220: Reset driver for hisilicon hi6220 SoC Chen Feng
2015-11-18 17:27 ` Philipp Zabel [this message]
2015-11-19 1:56 ` chenfeng
2015-10-30 3:19 ` [PATCH V6 RESEND 3/3] arm64: dts: Add reset dts config for Hisilicon Hi6220 SoC Chen Feng
2015-11-18 17:26 ` [PATCH V6 RESEND 1/3] reset: hisilicon: document hisi-hi6220 reset controllers bindings Philipp Zabel
2015-11-18 17:27 ` Philipp Zabel
2015-11-19 1:54 ` chenfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1447867675.23650.0.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=puck.chen@aliyun.com \
--cc=puck.chen@hisilicon.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®