mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexandra Yates <alexandra.yates@linux.intel.com>
To: srinivas.pandruvada@linux.intel.com, lenb@kernel.org,
	viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, rjw@rjwysocki.net
Cc: Alexandra Yates <alexandra.yates@linux.intel.com>
Subject: [PATCH V3] SKL intel_pstate update MSR values when changing governors
Date: Wed, 18 Nov 2015 14:58:40 -0800	[thread overview]
Message-ID: <1447887520-10399-1-git-send-email-alexandra.yates@linux.intel.com> (raw)
In-Reply-To: <SKL intel_pstate update MSR values when changing governors>

When changing from powersave to performance governors
Intel_pstate fails to update the MSR values that reflect the
max_perf_pct to 100%. For instance in SKL reading rdmsr 0x774:

Governor 	MSR			max_perf_pct
=========	========		============
Powersave 	80002808		100%
Powersave	80002008		80%
Performance	80002028 [error]	100%
Performance	80002828 [expected]	100%

The line label [error] shows the culprit. At this point the MSR
should reflect the max_perf_pct that is 100%, that corresponds
to MSR 80002828 as shown on the next line of the example. Which
is the maximum performance for the Performance governor.
Instead it holds back the MSR value previously set by the
Powersave, in this case 80002028.

This patch allows the system to print the correct MSR value
80002828 that corresponds to the 100% max_perf_pct when changing
from powersave to performance governors.

For more information on the MSR values for SKL please visit
ISDM under Managing HWP.

Signed-off-by: Alexandra Yates <alexandra.yates@linux.intel.com>
---
 drivers/cpufreq/intel_pstate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 2e31d09..0eeb7da 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1242,6 +1242,8 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
 	    policy->max >= policy->cpuinfo.max_freq) {
 		pr_debug("intel_pstate: set performance\n");
 		limits = &performance_limits;
+		if (hwp_active)
+			intel_pstate_hwp_set();
 		return 0;
 	}
 
-- 
1.9.1


  parent reply	other threads:[~2015-11-18 22:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <SKL intel_pstate update MSR values when changing governors>
2015-11-18  1:58 ` [PATCH V2] " Alexandra Yates
2015-11-18  2:15   ` Srinivas Pandruvada
2015-11-18 22:58 ` Alexandra Yates [this message]
2015-11-21  0:16   ` [PATCH V3] " Srinivas Pandruvada
2015-11-24  1:09     ` Rafael J. Wysocki
2015-11-24  1:17       ` Srinivas Pandruvada
2015-11-24 14:28         ` Rafael J. Wysocki
2015-11-24 15:57           ` Srinivas Pandruvada
2015-11-24 16:36             ` Rafael J. Wysocki
2015-11-24 16:27               ` Srinivas Pandruvada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447887520-10399-1-git-send-email-alexandra.yates@linux.intel.com \
    --to=alexandra.yates@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome