mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Christoph Hellwig <hch@infradead.org>,
	Hannes Reinecke <hare@suse.de>,
	Bart Van Assche <bart.vanassche@sandisk.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	Julian Calaby <julian.calaby@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k
Date: Tue, 24 Nov 2015 10:42:24 +0100	[thread overview]
Message-ID: <1448358147-23663-1-git-send-email-linux@rasmusvillemoes.dk> (raw)

This reduces the impact of choosing CONFIG_SCSI_CONSTANTS by about 8KB.

2dd951ecd511 ("scsi: Conditionally compile in constants.c") updated
the Kconfig help text from 12KB to 75KB. The 12K predated git so was
certainly outdated. But I'm not sure where the 75K comes from; using
size(1) on a defconfig (with/without this config option) vmlinux shows
a difference of about 47K, and 39K after these patches are applied. In
any case, I've left the Kconfig text alone, since I'm not sure I'm
counting the same way the 75K was computed (I'm fairly certain of the
8K delta, however).

Tested with a trivial module calling scsi_extd_sense_format with a few
random known codes and comparing the result to the expected value.

v2: prepend patch to unsplit a few string literals for greppability,
leave the NULL sentinel in the .c file in 2/3 (it's removed in 3/3
either way).

Rasmus Villemoes (3):
  scsi: make some Additional Sense strings more grep'able
  scsi: move Additional Sense Codes to separate file
  scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k

 drivers/scsi/constants.c   | 859 ++-------------------------------------------
 drivers/scsi/sense_codes.h | 826 +++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 847 insertions(+), 838 deletions(-)
 create mode 100644 drivers/scsi/sense_codes.h

-- 
2.6.1


             reply	other threads:[~2015-11-24  9:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24  9:42 Rasmus Villemoes [this message]
2015-11-24  9:42 ` [PATCH v2 1/3] scsi: make some Additional Sense strings more grep'able Rasmus Villemoes
2015-12-22 20:25   ` Douglas Gilbert
2015-11-24  9:42 ` [PATCH v2 2/3] scsi: move Additional Sense Codes to separate file Rasmus Villemoes
2015-12-22 20:25   ` Douglas Gilbert
2015-11-24  9:42 ` [PATCH v2 3/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Rasmus Villemoes
2015-12-22 20:25   ` Douglas Gilbert
2015-11-24 15:09 ` [PATCH v2 0/3] " Hannes Reinecke
2015-12-22 20:25 ` Douglas Gilbert
2016-03-08 19:52 ` Rasmus Villemoes
2016-03-22  7:54   ` Christoph Hellwig
2016-03-22 19:32     ` [PATCH v3 " Rasmus Villemoes
2016-03-22 19:32       ` [PATCH v3 1/3] scsi: make some Additional Sense strings more grep'able Rasmus Villemoes
2016-03-22 19:32       ` [PATCH v3 2/3] scsi: move Additional Sense Codes to separate file Rasmus Villemoes
2016-03-22 19:32       ` [PATCH v3 3/3] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Rasmus Villemoes
2016-03-23  7:39       ` [PATCH v3 0/3] " Christoph Hellwig
2016-03-23 20:50       ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448358147-23663-1-git-send-email-linux@rasmusvillemoes.dk \
    --to=linux@rasmusvillemoes.dk \
    --cc=JBottomley@odin.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=julian.calaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®