From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: minyard@acm.org, openipmi-developer@lists.sourceforge.net
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 1/4] ipmi: constify the name parameter of ipmi_smi_add_proc_entry
Date: Wed, 25 Nov 2015 14:43:22 +0100 [thread overview]
Message-ID: <1448459006-6118-1-git-send-email-clabbe.montjoie@gmail.com> (raw)
The name parameter of ipmi_smi_add_proc_entry() is never modified.
Furthermore, the name parameter of ipmi_smi_add_proc_entry is always given
string literal.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/char/ipmi/ipmi_msghandler.c | 2 +-
include/linux/ipmi_smi.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index 94fb407..ff64600 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2121,7 +2121,7 @@ static const struct file_operations smi_stats_proc_ops = {
};
#endif /* CONFIG_PROC_FS */
-int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,
+int ipmi_smi_add_proc_entry(ipmi_smi_t smi, const char *name,
const struct file_operations *proc_ops,
void *data)
{
diff --git a/include/linux/ipmi_smi.h b/include/linux/ipmi_smi.h
index f8cea14..4ceabae 100644
--- a/include/linux/ipmi_smi.h
+++ b/include/linux/ipmi_smi.h
@@ -245,7 +245,7 @@ static inline void ipmi_free_smi_msg(struct ipmi_smi_msg *msg)
/* Allow the lower layer to add things to the proc filesystem
directory for this interface. Note that the entry will
automatically be dstroyed when the interface is destroyed. */
-int ipmi_smi_add_proc_entry(ipmi_smi_t smi, char *name,
+int ipmi_smi_add_proc_entry(ipmi_smi_t smi, const char *name,
const struct file_operations *proc_ops,
void *data);
--
2.4.10
next reply other threads:[~2015-11-25 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 13:43 LABBE Corentin [this message]
2015-11-25 13:43 ` [PATCH 2/4] ipmi: constify the reason parameter of start_error_recovery LABBE Corentin
2015-11-25 13:43 ` [PATCH 4/4] ipmi: replace simple_strtoul by kstrtox LABBE Corentin
2015-11-25 14:29 ` [PATCH 3/4] ipmi: Replace all printk(KERN_xxx by their pr_xxx counterpart LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448459006-6118-1-git-send-email-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®