From: LABBE Corentin <clabbe.montjoie@gmail.com>
To: minyard@acm.org, openipmi-developer@lists.sourceforge.net
Cc: LABBE Corentin <clabbe.montjoie@gmail.com>, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] ipmi: constify the reason parameter of start_error_recovery
Date: Wed, 25 Nov 2015 14:43:23 +0100 [thread overview]
Message-ID: <1448459006-6118-2-git-send-email-clabbe.montjoie@gmail.com> (raw)
In-Reply-To: <1448459006-6118-1-git-send-email-clabbe.montjoie@gmail.com>
Both start_error_recovery() function are different but they didn't
modify the reason parameter.
Furthermore, the reason parameter is always given string literal.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/char/ipmi/ipmi_kcs_sm.c | 2 +-
drivers/char/ipmi/ipmi_smic_sm.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_kcs_sm.c b/drivers/char/ipmi/ipmi_kcs_sm.c
index 1da61af..9ec38e6 100644
--- a/drivers/char/ipmi/ipmi_kcs_sm.c
+++ b/drivers/char/ipmi/ipmi_kcs_sm.c
@@ -202,7 +202,7 @@ static inline void write_next_byte(struct si_sm_data *kcs)
(kcs->write_count)--;
}
-static inline void start_error_recovery(struct si_sm_data *kcs, char *reason)
+static inline void start_error_recovery(struct si_sm_data *kcs, const char *reason)
{
(kcs->error_retries)++;
if (kcs->error_retries > MAX_ERROR_RETRIES) {
diff --git a/drivers/char/ipmi/ipmi_smic_sm.c b/drivers/char/ipmi/ipmi_smic_sm.c
index 8f7c73f..21ad645 100644
--- a/drivers/char/ipmi/ipmi_smic_sm.c
+++ b/drivers/char/ipmi/ipmi_smic_sm.c
@@ -227,7 +227,7 @@ static inline void write_si_sm_data(struct si_sm_data *smic,
smic->io->outputb(smic->io, 0, data);
}
-static inline void start_error_recovery(struct si_sm_data *smic, char *reason)
+static inline void start_error_recovery(struct si_sm_data *smic, const char *reason)
{
(smic->error_retries)++;
if (smic->error_retries > SMIC_MAX_ERROR_RETRIES) {
--
2.4.10
next prev parent reply other threads:[~2015-11-25 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 13:43 [PATCH 1/4] ipmi: constify the name parameter of ipmi_smi_add_proc_entry LABBE Corentin
2015-11-25 13:43 ` LABBE Corentin [this message]
2015-11-25 13:43 ` [PATCH 4/4] ipmi: replace simple_strtoul by kstrtox LABBE Corentin
2015-11-25 14:29 ` [PATCH 3/4] ipmi: Replace all printk(KERN_xxx by their pr_xxx counterpart LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448459006-6118-2-git-send-email-clabbe.montjoie@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®