* [PATCH] mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags
@ 2015-11-25 18:26 Saurabh Sengar
2015-12-04 14:56 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Saurabh Sengar @ 2015-11-25 18:26 UTC (permalink / raw)
To: ulf.hansson, linux-mmc, linux-kernel; +Cc: Saurabh Sengar
If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
drivers/mmc/host/of_mmc_spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
index 6e218fb..660170c 100644
--- a/drivers/mmc/host/of_mmc_spi.c
+++ b/drivers/mmc/host/of_mmc_spi.c
@@ -55,8 +55,8 @@ static int of_mmc_spi_init(struct device *dev,
{
struct of_mmc_spi *oms = to_of_mmc_spi(dev);
- return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
- dev_name(dev), mmc);
+ return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
+ IRQF_ONESHOT, dev_name(dev), mmc);
}
static void of_mmc_spi_exit(struct device *dev, void *mmc)
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags
2015-11-25 18:26 [PATCH] mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags Saurabh Sengar
@ 2015-12-04 14:56 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2015-12-04 14:56 UTC (permalink / raw)
To: Saurabh Sengar; +Cc: linux-mmc, linux-kernel
On 25 November 2015 at 19:26, Saurabh Sengar <saurabh.truth@gmail.com> wrote:
> If no primary handler is specified for threaded_irq then a
> default one is assigned which always returns IRQ_WAKE_THREAD.
> This handler requires the IRQF_ONESHOT, because the source of
> interrupt is not disabled
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/of_mmc_spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/of_mmc_spi.c b/drivers/mmc/host/of_mmc_spi.c
> index 6e218fb..660170c 100644
> --- a/drivers/mmc/host/of_mmc_spi.c
> +++ b/drivers/mmc/host/of_mmc_spi.c
> @@ -55,8 +55,8 @@ static int of_mmc_spi_init(struct device *dev,
> {
> struct of_mmc_spi *oms = to_of_mmc_spi(dev);
>
> - return request_threaded_irq(oms->detect_irq, NULL, irqhandler, 0,
> - dev_name(dev), mmc);
> + return request_threaded_irq(oms->detect_irq, NULL, irqhandler,
> + IRQF_ONESHOT, dev_name(dev), mmc);
> }
>
> static void of_mmc_spi_exit(struct device *dev, void *mmc)
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-04 14:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-25 18:26 [PATCH] mmc: of_mmc_spi: Add IRQF_ONESHOT to interrupt flags Saurabh Sengar
2015-12-04 14:56 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®