mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jin Qian <jinqian@android.com>
To: "Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Greg Hackmann" <ghackmann@google.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Yu Ning" <yu.ning@intel.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Christoffer Dall" <christoffer.dall@linaro.org>,
	"Peter Senna Tschudin" <peter.senna@gmail.com>,
	"Jason Hu" <jia-cheng.hu@intel.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jin Qian <jinqian@android.com>
Subject: [PATCH v3 4/8] platform: goldfish: pipe: add devicetree bindings
Date: Wed,  2 Dec 2015 11:35:59 -0800	[thread overview]
Message-ID: <1449084968-30211-4-git-send-email-jinqian@android.com> (raw)
In-Reply-To: <1449084968-30211-1-git-send-email-jinqian@android.com>

From: Greg Hackmann <ghackmann@google.com>

Add bindings so we don't need to rely on goldfish virtual bus for
probing any more, which means we don't need ARM and MIPS goldfish
board code for instantiating the bus.

In the long term we would like to move towards replacing the Android
pipe with virtio-vsock that is currently under development.

Signed-off-by: Greg Hackmann <ghackmann@google.com>
Signed-off-by: Jin Qian <jinqian@android.com>
---
 Documentation/devicetree/bindings/goldfish/pipe.txt | 17 +++++++++++++++++
 drivers/platform/goldfish/goldfish_pipe.c           | 10 +++++++++-
 2 files changed, 26 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/goldfish/pipe.txt

diff --git a/Documentation/devicetree/bindings/goldfish/pipe.txt b/Documentation/devicetree/bindings/goldfish/pipe.txt
new file mode 100644
index 0000000..e417a31
--- /dev/null
+++ b/Documentation/devicetree/bindings/goldfish/pipe.txt
@@ -0,0 +1,17 @@
+Android Goldfish QEMU Pipe
+
+Andorid pipe virtual device generated by android emulator.
+
+Required properties:
+
+- compatible : should contain "google,android-pipe" to match emulator
+- reg        : <registers mapping>
+- interrupts : <interrupt mapping>
+
+Example:
+
+	android_pipe@a010000 {
+		compatible = "google,android-pipe";
+		reg = <ff018000 0x2000>;
+		interrupts = <0x12>;
+	};
diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 20a9337..0b187ff 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -624,11 +624,19 @@ static int goldfish_pipe_remove(struct platform_device *pdev)
 	return 0;
 }
 
+static const struct of_device_id goldfish_pipe_of_match[] = {
+	{ .compatible = "google,android-pipe", },
+	{},
+};
+MODULE_DEVICE_TABLE(of, goldfish_pipe_of_match);
+
 static struct platform_driver goldfish_pipe = {
 	.probe = goldfish_pipe_probe,
 	.remove = goldfish_pipe_remove,
 	.driver = {
-		.name = "goldfish_pipe"
+		.name = "goldfish_pipe",
+		.owner = THIS_MODULE,
+		.of_match_table = goldfish_pipe_of_match,
 	}
 };
 
-- 
2.6.0.rc2.230.g3dd15c0


  parent reply	other threads:[~2015-12-02 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 19:35 [PATCH v3 1/8] goldfish: refactor goldfish platform configs Jin Qian
2015-12-02 19:35 ` [PATCH v3 2/8] android_pipe: don't be clever with #define offsets Jin Qian
2015-12-02 20:11   ` Joe Perches
2015-12-02 19:35 ` [PATCH v3 3/8] android_pipe: Pin pages to memory while copying and other cleanups Jin Qian
2015-12-02 19:35 ` Jin Qian [this message]
2015-12-04 14:57   ` [PATCH v3 4/8] platform: goldfish: pipe: add devicetree bindings Rob Herring
2015-12-02 19:36 ` [PATCH v3 5/8] platform: goldfish: pipe: don't log when dropping PIPE_ERROR_AGAIN Jin Qian
2015-12-02 19:36 ` [PATCH v3 6/8] [MIPS] Enable platform support for Goldfish virtual devices Jin Qian
2015-12-02 19:36 ` [PATCH v3 7/8] goldfish_pipe: Pass physical addresses to the device if supported Jin Qian
2015-12-02 19:36 ` [PATCH v3 8/8] goldfish: Enable ACPI-based enumeration for android pipe Jin Qian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449084968-30211-4-git-send-email-jinqian@android.com \
    --to=jinqian@android.com \
    --cc=alex.bennee@linaro.org \
    --cc=christoffer.dall@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jia-cheng.hu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=peter.senna@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=yu.ning@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome