mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jin Qian <jinqian@android.com>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Greg Hackmann" <ghackmann@google.com>,
	"Christoffer Dall" <christoffer.dall@linaro.org>,
	"Joe Perches" <joe@perches.com>,
	"Jason Hu" <jia-cheng.hu@intel.com>,
	"Yu Ning" <yu.ning@intel.com>,
	"Peter Senna Tschudin" <peter.senna@gmail.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	linux-kernel@vger.kernel.org
Cc: Jin Qian <jinqian@android.com>
Subject: [PATCH v3 5/8] platform: goldfish: pipe: don't log when dropping PIPE_ERROR_AGAIN
Date: Wed,  2 Dec 2015 11:36:00 -0800	[thread overview]
Message-ID: <1449084968-30211-5-git-send-email-jinqian@android.com> (raw)
In-Reply-To: <1449084968-30211-1-git-send-email-jinqian@android.com>

From: Greg Hackmann <ghackmann@google.com>

On PIPE_ERROR_AGAIN, just stopping in the middle of a transfer and
returning the number of bytes actually handled is the right behavior.

Other errors should be returned on the next read() or write() call.
Continue logging those until we confirm nothing actually relies on the
existing (wrong) behavior of dropping errors on the floor.

Signed-off-by: Greg Hackmann <ghackmann@google.com>
Signed-off-by: Jin Qian <jinqian@android.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 0b187ff..7a56be9 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -346,7 +346,8 @@ static ssize_t goldfish_pipe_read_write(struct file *filp, char __user *buffer,
 			 * cannot change it until we check if any user space
 			 * ABI relies on this behavior.
 			 */
-			pr_info_ratelimited("android_pipe: backend returned error %d on %s\n",
+			if (status != PIPE_ERROR_AGAIN)
+				pr_info_ratelimited("goldfish_pipe: backend returned error %d on %s\n",
 					status, is_write ? "write" : "read");
 			ret = 0;
 			break;
-- 
2.6.0.rc2.230.g3dd15c0


  parent reply	other threads:[~2015-12-02 19:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-02 19:35 [PATCH v3 1/8] goldfish: refactor goldfish platform configs Jin Qian
2015-12-02 19:35 ` [PATCH v3 2/8] android_pipe: don't be clever with #define offsets Jin Qian
2015-12-02 20:11   ` Joe Perches
2015-12-02 19:35 ` [PATCH v3 3/8] android_pipe: Pin pages to memory while copying and other cleanups Jin Qian
2015-12-02 19:35 ` [PATCH v3 4/8] platform: goldfish: pipe: add devicetree bindings Jin Qian
2015-12-04 14:57   ` Rob Herring
2015-12-02 19:36 ` Jin Qian [this message]
2015-12-02 19:36 ` [PATCH v3 6/8] [MIPS] Enable platform support for Goldfish virtual devices Jin Qian
2015-12-02 19:36 ` [PATCH v3 7/8] goldfish_pipe: Pass physical addresses to the device if supported Jin Qian
2015-12-02 19:36 ` [PATCH v3 8/8] goldfish: Enable ACPI-based enumeration for android pipe Jin Qian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449084968-30211-5-git-send-email-jinqian@android.com \
    --to=jinqian@android.com \
    --cc=alex.bennee@linaro.org \
    --cc=christoffer.dall@linaro.org \
    --cc=ghackmann@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jia-cheng.hu@intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter.senna@gmail.com \
    --cc=yu.ning@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome