mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/4] Xeon PHI Knights Landing support for EDAC module
@ 2015-12-03  9:48 Hubert Chrzaniuk
  2015-12-03  9:48 ` [PATCH 1/4] EDAC: add DDR4 flag Hubert Chrzaniuk
                   ` (4 more replies)
  0 siblings, 5 replies; 12+ messages in thread
From: Hubert Chrzaniuk @ 2015-12-03  9:48 UTC (permalink / raw)
  To: hubert.chrzaniuk, lukasz.anaczkowski, mchehab, dougthompson, bp
  Cc: linux-edac, linux-kernel

Series of patches that enable support for Knights Landing processor which is based on Silvermont microarchitecture.

First 3 patches are pretty much straightforward and self-explantory.
Last one is the biggest, however, is logically consistent and breaking into many smaller patches does not make much sense.

Patches apply on top of 4.4-rc3

Jim Snow (4):
  EDAC: add DDR4 flag
  sb_edac: virtualize several hard-coded functions
  sb_edac: support for duplicate device IDs
  sb_edac: add Knights Landing (Xeon Phi gen 2) support

 drivers/edac/sb_edac.c | 1065 +++++++++++++++++++++++++++++++++++++++++++++---
 include/linux/edac.h   |    6 +-
 2 files changed, 1005 insertions(+), 66 deletions(-)

-- 
1.8.3.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.


^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 0/4] Xeon PHI Knights Landing support for EDAC module
@ 2015-12-02 15:38 Hubert Chrzaniuk
  2015-12-02 15:38 ` [PATCH 3/4] sb_edac: support for duplicate device IDs Hubert Chrzaniuk
  0 siblings, 1 reply; 12+ messages in thread
From: Hubert Chrzaniuk @ 2015-12-02 15:38 UTC (permalink / raw)
  To: hubert.chrzaniuk, lukasz.anaczkowski, mchehab, dougthompson, bp
  Cc: linux-edac, linux-kernel

Series of patches that enable support for Knights Landing processor
which is based on Silvermont microarchitecture.

First 3 patches are pretty much straightforward and self-explantory.

Last one is the biggest, however, is logically consistent and breaking
into many smaller patches does not make much sense.

Patches apply on top of 4.4-rc3.

Jim Snow (4):
  EDAC: add DDR4 flag
  sb_edac: virtualize several hard-coded functions
  sb_edac: support for duplicate device IDs
  sb_edac: add Knights Landing (Xeon Phi gen 2) support

 drivers/edac/sb_edac.c | 1065 +++++++++++++++++++++++++++++++++++++++++++++---
 include/linux/edac.h   |    6 +-
 2 files changed, 1005 insertions(+), 66 deletions(-)

-- 
1.8.3.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.


^ permalink raw reply	[flat|nested] 12+ messages in thread
* [PATCH 3/4] sb_edac: support for duplicate device IDs
@ 2015-11-30 17:22 Chrzaniuk, Hubert
  0 siblings, 0 replies; 12+ messages in thread
From: Chrzaniuk, Hubert @ 2015-11-30 17:22 UTC (permalink / raw)
  To: mchehab, dougthompson, bp; +Cc: linux-edac, linux-kernel, Anaczkowski, Lukasz

Add options to sbridge_get_all_devices to allow
for duplicate device IDs and devices that are scattered
across mulitple PCI buses.

Signed-off-by: Jim Snow <jim.m.snow@intel.com>
Signed-off-by: Lukasz Anaczkowski <lukasz.anaczkowski@intel.com>
---
 drivers/edac/sb_edac.c | 40 ++++++++++++++++++++++++++++++++--------
 1 file changed, 32 insertions(+), 8 deletions(-)

diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
index 2e50a3e..c8fbde2 100644
--- a/drivers/edac/sb_edac.c
+++ b/drivers/edac/sb_edac.c
@@ -637,10 +637,19 @@ static inline int numcol(u32 mtr)
 	return 1 << cols;
 }
 
-static struct sbridge_dev *get_sbridge_dev(u8 bus)
+static struct sbridge_dev *get_sbridge_dev(u8 bus, int multi_bus)
 {
 	struct sbridge_dev *sbridge_dev;
 
+	/*
+	 * If we have devices scattered across several busses that pertain
+	 * to the same memory controller, we'll lump them all together.
+	 */
+	if (multi_bus) {
+		return list_first_entry_or_null(&sbridge_edac_list,
+				struct sbridge_dev, list);
+	}
+
 	list_for_each_entry(sbridge_dev, &sbridge_edac_list, list) {
 		if (sbridge_dev->bus == bus)
 			return sbridge_dev;
@@ -1588,7 +1597,8 @@ static void sbridge_put_all_devices(void)
 static int sbridge_get_onedevice(struct pci_dev **prev,
 				 u8 *num_mc,
 				 const struct pci_id_table *table,
-				 const unsigned devno)
+				 const unsigned devno,
+				 const int multi_bus)
 {
 	struct sbridge_dev *sbridge_dev;
 	const struct pci_id_descr *dev_descr = &table->descr[devno];
@@ -1624,7 +1634,7 @@ static int sbridge_get_onedevice(struct pci_dev **prev,
 	}
 	bus = pdev->bus->number;
 
-	sbridge_dev = get_sbridge_dev(bus);
+	sbridge_dev = get_sbridge_dev(bus, multi_bus);
 	if (!sbridge_dev) {
 		sbridge_dev = alloc_sbridge_dev(bus, table);
 		if (!sbridge_dev) {
@@ -1673,21 +1683,32 @@ static int sbridge_get_onedevice(struct pci_dev **prev,
  * @num_mc: pointer to the memory controllers count, to be incremented in case
  *	    of success.
  * @table: model specific table
+ * @allow_dups: allow for multiple devices to exist with the same device id
+ *              (as implemented, this isn't expected to work correctly in the
+ *              multi-socket case).
+ * @multi_bus: don't assume devices on different buses belong to different
+ *             memory controllers.
  *
  * returns 0 in case of success or error code
  */
-static int sbridge_get_all_devices(u8 *num_mc,
-				   const struct pci_id_table *table)
+static int sbridge_get_all_devices_full(u8 *num_mc,
+					const struct pci_id_table *table,
+					int allow_dups,
+					int multi_bus)
 {
 	int i, rc;
 	struct pci_dev *pdev = NULL;
 
 	while (table && table->descr) {
 		for (i = 0; i < table->n_devs; i++) {
-			pdev = NULL;
+			if (!allow_dups || i == 0 ||
+					table->descr[i].dev_id !=
+						table->descr[i-1].dev_id) {
+				pdev = NULL;
+			}
 			do {
 				rc = sbridge_get_onedevice(&pdev, num_mc,
-							   table, i);
+							   table, i, multi_bus);
 				if (rc < 0) {
 					if (i == 0) {
 						i = table->n_devs;
@@ -1696,7 +1717,7 @@ static int sbridge_get_all_devices(u8 *num_mc,
 					sbridge_put_all_devices();
 					return -ENODEV;
 				}
-			} while (pdev);
+			} while (pdev && !allow_dups);
 		}
 		table++;
 	}
@@ -1704,6 +1725,9 @@ static int sbridge_get_all_devices(u8 *num_mc,
 	return 0;
 }
 
+#define sbridge_get_all_devices(num_mc, table) \
+		sbridge_get_all_devices_full(num_mc, table, 0, 0)
+
 static int sbridge_mci_bind_devs(struct mem_ctl_info *mci,
 				 struct sbridge_dev *sbridge_dev)
 {
-- 
1.8.3.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.


^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2015-12-07 11:24 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-03  9:48 [PATCH 0/4] Xeon PHI Knights Landing support for EDAC module Hubert Chrzaniuk
2015-12-03  9:48 ` [PATCH 1/4] EDAC: add DDR4 flag Hubert Chrzaniuk
2015-12-03 10:48   ` Borislav Petkov
2015-12-03 19:16     ` Luck, Tony
2015-12-03 19:43       ` Borislav Petkov
2015-12-03 21:53         ` Luck, Tony
2015-12-03  9:48 ` [PATCH 2/4] sb_edac: virtualize several hard-coded functions Hubert Chrzaniuk
2015-12-03  9:48 ` [PATCH 3/4] sb_edac: support for duplicate device IDs Hubert Chrzaniuk
2015-12-03  9:48 ` [PATCH 4/4] sb_edac: add Knights Landing (Xeon Phi gen 2) support Hubert Chrzaniuk
2015-12-07 11:24 ` [PATCH 0/4] Xeon PHI Knights Landing support for EDAC module Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2015-12-02 15:38 Hubert Chrzaniuk
2015-12-02 15:38 ` [PATCH 3/4] sb_edac: support for duplicate device IDs Hubert Chrzaniuk
2015-11-30 17:22 Chrzaniuk, Hubert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®