* [PATCH] drm: msm: dsi: Added missing mutex_unlock
@ 2015-12-06 19:49 Saurabh Sengar
2015-12-07 16:55 ` Rob Clark
0 siblings, 1 reply; 2+ messages in thread
From: Saurabh Sengar @ 2015-12-06 19:49 UTC (permalink / raw)
To: airlied, robdclark, hali, architt, sviau, u.kleine-koenig,
dri-devel, linux-kernel
Cc: Saurabh Sengar
in case of failed to get iova, function was returning without releasing
the mutex. Added it.
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 4c49868..13f937b 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -849,11 +849,11 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size)
}
ret = msm_gem_get_iova_locked(msm_host->tx_gem_obj, 0, &iova);
+ mutex_unlock(&dev->struct_mutex);
if (ret) {
pr_err("%s: failed to get iova, %d\n", __func__, ret);
return ret;
}
- mutex_unlock(&dev->struct_mutex);
if (iova & 0x07) {
pr_err("%s: buf NOT 8 bytes aligned\n", __func__);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm: msm: dsi: Added missing mutex_unlock
2015-12-06 19:49 [PATCH] drm: msm: dsi: Added missing mutex_unlock Saurabh Sengar
@ 2015-12-07 16:55 ` Rob Clark
0 siblings, 0 replies; 2+ messages in thread
From: Rob Clark @ 2015-12-07 16:55 UTC (permalink / raw)
To: Saurabh Sengar
Cc: David Airlie, Hai Li, Archit Taneja, Stephane Viau,
Uwe Kleine-König, dri-devel, Linux Kernel Mailing List
On Sun, Dec 6, 2015 at 2:49 PM, Saurabh Sengar <saurabh.truth@gmail.com> wrote:
> in case of failed to get iova, function was returning without releasing
> the mutex. Added it.
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
Reviewed-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 4c49868..13f937b 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -849,11 +849,11 @@ static int dsi_tx_buf_alloc(struct msm_dsi_host *msm_host, int size)
> }
>
> ret = msm_gem_get_iova_locked(msm_host->tx_gem_obj, 0, &iova);
> + mutex_unlock(&dev->struct_mutex);
> if (ret) {
> pr_err("%s: failed to get iova, %d\n", __func__, ret);
> return ret;
> }
> - mutex_unlock(&dev->struct_mutex);
>
> if (iova & 0x07) {
> pr_err("%s: buf NOT 8 bytes aligned\n", __func__);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-07 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-06 19:49 [PATCH] drm: msm: dsi: Added missing mutex_unlock Saurabh Sengar
2015-12-07 16:55 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®