From: Petr Mladek <pmladek@suse.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Russell King <rmk+kernel@arm.linux.org.uk>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jiri Kosina <jkosina@suse.com>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
linux-arm-kernel@lists.infradead.org,
adi-buildroot-devel@lists.sourceforge.net,
linux-cris-kernel@axis.com, linux-mips@linux-mips.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
Petr Mladek <pmladek@suse.com>
Subject: [PATCH v3 0/4] Cleaning printk stuff in NMI context
Date: Wed, 9 Dec 2015 14:21:01 +0100 [thread overview]
Message-ID: <1449667265-17525-1-git-send-email-pmladek@suse.com> (raw)
This patch set generalizes the already existing solution for
printing NMI messages. The main idea comes from Peter Zijlstra.
Changes against v2:
+ fixed compilation problems reported by 0-day build robot
+ MN10300 and Xtensa architectures will get handled separately
+ dropped the patch that printed NMI messages directly when Oops
in progress; it made the solution less reliable
+ made the size of the buffer configurable; use real numbers
instead of PAGE_SIZE
Changes against v1:
+ rebased on top of 4.4-rc2; there the old implementation was
moved to lib/nmi_backtrace.c and used also on arm; I hope that
I got the arm side correctly; I was not able to test on arm :-(
+ defined HAVE_NMI on arm for !CPU_V7M instead of !CPU_V7;
handle_fiq_as_nmi() is called from entry-armv.S that
is compiled when !CPU_V7M
+ defined HAVE_NMI also on mips; it calls nmi_enter() and
seems to have real NMIs (or am I wrong?)
+ serialized backtraces when printing directly
(oops_in_progress)
Petr Mladek (4):
printk/nmi: Generic solution for safe printk in NMI
printk/nmi: Use IRQ work only when ready
printk/nmi: Warn when some message has been lost in NMI context
printk/nmi: Increase the size of NMI buffer and make it configurable
arch/Kconfig | 7 ++
arch/arm/Kconfig | 2 +
arch/arm/kernel/smp.c | 2 +
arch/avr32/Kconfig | 1 +
arch/blackfin/Kconfig | 1 +
arch/cris/Kconfig | 1 +
arch/mips/Kconfig | 1 +
arch/powerpc/Kconfig | 1 +
arch/s390/Kconfig | 1 +
arch/sh/Kconfig | 1 +
arch/sparc/Kconfig | 1 +
arch/tile/Kconfig | 1 +
arch/x86/Kconfig | 1 +
arch/x86/kernel/apic/hw_nmi.c | 1 -
include/linux/hardirq.h | 2 +
include/linux/percpu.h | 3 -
include/linux/printk.h | 12 ++-
init/Kconfig | 27 ++++++
init/main.c | 1 +
kernel/printk/Makefile | 1 +
kernel/printk/nmi.c | 218 ++++++++++++++++++++++++++++++++++++++++++
kernel/printk/printk.c | 29 +++---
kernel/printk/printk.h | 55 +++++++++++
lib/nmi_backtrace.c | 89 +----------------
24 files changed, 352 insertions(+), 107 deletions(-)
create mode 100644 kernel/printk/nmi.c
create mode 100644 kernel/printk/printk.h
--
1.8.5.6
next reply other threads:[~2015-12-09 13:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:21 Petr Mladek [this message]
2015-12-09 13:21 ` [PATCH v3 1/4] printk/nmi: Generic solution for safe printk in NMI Petr Mladek
2015-12-09 23:50 ` Andrew Morton
2015-12-10 15:26 ` Petr Mladek
2015-12-09 13:21 ` [PATCH v3 2/4] printk/nmi: Use IRQ work only when ready Petr Mladek
2015-12-09 13:21 ` [PATCH v3 3/4] printk/nmi: Warn when some message has been lost in NMI context Petr Mladek
2015-12-09 13:21 ` [PATCH v3 4/4] printk/nmi: Increase the size of NMI buffer and make it configurable Petr Mladek
2015-12-11 11:10 ` Geert Uytterhoeven
2015-12-11 12:41 ` Petr Mladek
2015-12-11 12:47 ` Arnd Bergmann
2015-12-11 12:50 ` Geert Uytterhoeven
2015-12-11 22:57 ` Andrew Morton
2015-12-11 23:21 ` Russell King - ARM Linux
2015-12-11 23:26 ` Jiri Kosina
2015-12-18 10:18 ` Daniel Thompson
2015-12-18 11:29 ` Peter Zijlstra
2015-12-18 12:11 ` Peter Zijlstra
2015-12-18 23:03 ` Andrew Morton
2015-12-18 14:52 ` Petr Mladek
2015-12-18 17:00 ` Daniel Thompson
2016-03-01 14:04 ` Daniel Thompson
2015-12-11 23:30 ` Andrew Morton
2015-12-15 14:26 ` Petr Mladek
2015-12-17 22:38 ` Andrew Morton
2015-12-18 16:18 ` Petr Mladek
2015-12-14 10:28 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449667265-17525-1-git-send-email-pmladek@suse.com \
--to=pmladek@suse.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=akpm@linux-foundation.org \
--cc=daniel.thompson@linaro.org \
--cc=jkosina@suse.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-cris-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=rostedt@goodmis.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®