* [PATCH] crypto: asymmetric_keys/signature.c does not need <module.h>
@ 2015-12-09 20:05 Paul Gortmaker
2015-12-12 5:44 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Paul Gortmaker @ 2015-12-09 20:05 UTC (permalink / raw)
To: linux-kernel; +Cc: Paul Gortmaker, Herbert Xu, David S. Miller, linux-crypto
This file does not contain any modular related function calls. So get
rid of module.h since it drags in a lot of other headers and adds to
the preprocessing load. It does export some symbols though, so we'll
need to ensure it has export.h present instead.
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
crypto/asymmetric_keys/signature.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/asymmetric_keys/signature.c b/crypto/asymmetric_keys/signature.c
index 7525fd183574..da0821eb69fd 100644
--- a/crypto/asymmetric_keys/signature.c
+++ b/crypto/asymmetric_keys/signature.c
@@ -13,7 +13,7 @@
#define pr_fmt(fmt) "SIG: "fmt
#include <keys/asymmetric-subtype.h>
-#include <linux/module.h>
+#include <linux/export.h>
#include <linux/err.h>
#include <crypto/public_key.h>
#include "asymmetric_keys.h"
--
2.5.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: asymmetric_keys/signature.c does not need <module.h>
2015-12-09 20:05 [PATCH] crypto: asymmetric_keys/signature.c does not need <module.h> Paul Gortmaker
@ 2015-12-12 5:44 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-12-12 5:44 UTC (permalink / raw)
To: Paul Gortmaker; +Cc: linux-kernel, David S. Miller, linux-crypto
On Wed, Dec 09, 2015 at 03:05:28PM -0500, Paul Gortmaker wrote:
> This file does not contain any modular related function calls. So get
> rid of module.h since it drags in a lot of other headers and adds to
> the preprocessing load. It does export some symbols though, so we'll
> need to ensure it has export.h present instead.
>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: linux-crypto@vger.kernel.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-12 5:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-09 20:05 [PATCH] crypto: asymmetric_keys/signature.c does not need <module.h> Paul Gortmaker
2015-12-12 5:44 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®