* [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros
@ 2015-12-10 18:18 Geyslan G. Bem
2015-12-11 16:30 ` Greg Kroah-Hartman
0 siblings, 1 reply; 4+ messages in thread
From: Geyslan G. Bem @ 2015-12-10 18:18 UTC (permalink / raw)
To: peter.senna
Cc: Geyslan G. Bem, Alan Stern, Greg Kroah-Hartman, linux-usb, linux-kernel
Don't use the 'do {} while (0)' wrapper in a single statement macro.
Caught by checkpatch: "WARNING: Single statement macros should not
use a do {} while (0) loop"
Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
Change in v3:
- There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS
false branch. Thus an empty #define is the choice.
---
drivers/usb/host/ehci.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index cfeebd8..c86194f 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -244,9 +244,9 @@ struct ehci_hcd { /* one per controller */
/* irq statistics */
#ifdef EHCI_STATS
struct ehci_stats stats;
-# define COUNT(x) do { (x)++; } while (0)
+# define COUNT(x) ((x)++)
#else
-# define COUNT(x) do {} while (0)
+# define COUNT(x)
#endif
/* debug files */
--
2.6.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros
2015-12-10 18:18 [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros Geyslan G. Bem
@ 2015-12-11 16:30 ` Greg Kroah-Hartman
2015-12-11 20:55 ` Geyslan G. Bem
0 siblings, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2015-12-11 16:30 UTC (permalink / raw)
To: Geyslan G. Bem; +Cc: peter.senna, Alan Stern, linux-usb, linux-kernel
On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote:
> Don't use the 'do {} while (0)' wrapper in a single statement macro.
>
> Caught by checkpatch: "WARNING: Single statement macros should not
> use a do {} while (0) loop"
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---
> Change in v3:
> - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS
> false branch. Thus an empty #define is the choice.
Odd numbering scheme of patches, I can't figure this out...
Can you resend this whole series so I know I got it all correct?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros
2015-12-11 16:30 ` Greg Kroah-Hartman
@ 2015-12-11 20:55 ` Geyslan G. Bem
2015-12-11 21:29 ` Geyslan G. Bem
0 siblings, 1 reply; 4+ messages in thread
From: Geyslan G. Bem @ 2015-12-11 20:55 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Peter Senna Tschudin, Alan Stern, linux-usb, LKML
2015-12-11 13:30 GMT-03:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote:
>> Don't use the 'do {} while (0)' wrapper in a single statement macro.
>>
>> Caught by checkpatch: "WARNING: Single statement macros should not
>> use a do {} while (0) loop"
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>> Change in v3:
>> - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS
>> false branch. Thus an empty #define is the choice.
>
> Odd numbering scheme of patches, I can't figure this out...
Greg,
I sent new versions only to modified ones.
9 is v1.
4 is v3.
rest is v2.
Next time I'll send new versions for all.
>
> Can you resend this whole series so I know I got it all correct?
I hope so. :-) Messing around with branches and merges here. I tell you soon.
>
> thanks,
>
> greg k-h
--
Regards,
Geyslan G. Bem
hackingbits.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros
2015-12-11 20:55 ` Geyslan G. Bem
@ 2015-12-11 21:29 ` Geyslan G. Bem
0 siblings, 0 replies; 4+ messages in thread
From: Geyslan G. Bem @ 2015-12-11 21:29 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Peter Senna Tschudin, Alan Stern, linux-usb, LKML
2015-12-11 17:55 GMT-03:00 Geyslan G. Bem <geyslan@gmail.com>:
> 2015-12-11 13:30 GMT-03:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
>> On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote:
>>> Don't use the 'do {} while (0)' wrapper in a single statement macro.
>>>
>>> Caught by checkpatch: "WARNING: Single statement macros should not
>>> use a do {} while (0) loop"
>>>
>>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>>> ---
>>> Change in v3:
>>> - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS
>>> false branch. Thus an empty #define is the choice.
>>
>> Odd numbering scheme of patches, I can't figure this out...
> Greg,
>
> I sent new versions only to modified ones.
> 9 is v1.
> 4 is v3.
> rest is v2.
>
> Next time I'll send new versions for all.
>
>>
>> Can you resend this whole series so I know I got it all correct?
> I hope so. :-) Messing around with branches and merges here. I tell you soon.
Greg, please, grab them.
[PATCH resend 0/9] usb: host: ehci.h cleanup
>
>>
>> thanks,
>>
>> greg k-h
>
>
>
> --
> Regards,
>
> Geyslan G. Bem
> hackingbits.com
--
Regards,
Geyslan G. Bem
hackingbits.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-11 21:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-10 18:18 [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros Geyslan G. Bem
2015-12-11 16:30 ` Greg Kroah-Hartman
2015-12-11 20:55 ` Geyslan G. Bem
2015-12-11 21:29 ` Geyslan G. Bem
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome