From: Tim Chen <tim.c.chen@linux.intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
"David S.Miller" <davem@davemloft.net>,
Stephan Mueller <smueller@chronox.de>,
Chandramouli Narayanan <mouli_7982@yahoo.com>,
Vinodh Gopal <vinodh.gopal@intel.com>,
James Guilford <james.guilford@intel.com>,
Wajdi Feghali <wajdi.k.feghali@intel.com>,
Jussi Kivilinna <jussi.kivilinna@iki.fi>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code
Date: Fri, 11 Dec 2015 08:54:40 -0800 [thread overview]
Message-ID: <1449852880.3057.15.camel@schen9-desk2.jf.intel.com> (raw)
In-Reply-To: <20151211032340.GC10399@gondor.apana.org.au>
On Fri, 2015-12-11 at 11:23 +0800, Herbert Xu wrote:
> On Thu, Dec 10, 2015 at 08:39:45AM -0800, Tim Chen wrote:
> >
> > The inner cipher is called synchronously from the outer layer
> > async cipher algorithm in cbc_mb_async_ablk_decrypt via
> >
> > err = crypto_blkcipher_crt(child_tfm)->decrypt(
> > &rctx->desc, req->dst, req->src, req->nbytes);
>
> We should avoid bypassing the API and directly calling crypto
> driver functions like this.
>
> What if you made it a proper ablkcipher and just called it through
> the API?
>
> Thanks,
Direct call I assume have less overhead. Let me think about
making the inner cipher ablkcipher. I may need to rewrite a lot
of the glue layer :(
Tim
next prev parent reply other threads:[~2015-12-11 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1449091633.git.tim.c.chen@linux.intel.com>
2015-12-02 20:01 ` [PATCH v4 0/5] crypto: x86 AES-CBC encryption with multibuffer Tim Chen
2015-12-02 20:02 ` [PATCH v4 1/5] crypto: Multi-buffer encryption infrastructure support Tim Chen
2015-12-02 20:02 ` [PATCH v4 2/5] crypto: AES CBC multi-buffer data structures Tim Chen
2015-12-02 20:02 ` [PATCH v4 3/5] crypto: AES CBC multi-buffer scheduler Tim Chen
2015-12-02 20:02 ` [PATCH v4 4/5] crypto: AES CBC by8 encryption Tim Chen
2015-12-02 20:02 ` [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code Tim Chen
2015-12-09 2:52 ` Herbert Xu
2015-12-09 17:23 ` Tim Chen
2015-12-10 1:45 ` Herbert Xu
2015-12-10 16:39 ` Tim Chen
2015-12-11 3:23 ` Herbert Xu
2015-12-11 16:54 ` Tim Chen [this message]
2015-12-12 5:48 ` Herbert Xu
2015-12-15 18:36 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449852880.3057.15.camel@schen9-desk2.jf.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=james.guilford@intel.com \
--cc=jussi.kivilinna@iki.fi \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mouli_7982@yahoo.com \
--cc=smueller@chronox.de \
--cc=vinodh.gopal@intel.com \
--cc=wajdi.k.feghali@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®