* [PATCH] wan: wanxl: add pci_disable_device in case of error
@ 2015-12-11 19:28 Saurabh Sengar
2015-12-14 21:22 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Saurabh Sengar @ 2015-12-11 19:28 UTC (permalink / raw)
To: khc, netdev, linux-kernel; +Cc: Saurabh Sengar
If there is 'no suitable DMA available' error, device should be disabled
before returning
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
drivers/net/wan/wanxl.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
index e73f138..a20d688 100644
--- a/drivers/net/wan/wanxl.c
+++ b/drivers/net/wan/wanxl.c
@@ -586,6 +586,7 @@ static int wanxl_pci_init_one(struct pci_dev *pdev,
if (pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(28)) ||
pci_set_dma_mask(pdev, DMA_BIT_MASK(28))) {
pr_err("No usable DMA configuration\n");
+ pci_disable_device(pdev);
return -EIO;
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] wan: wanxl: add pci_disable_device in case of error
2015-12-11 19:28 [PATCH] wan: wanxl: add pci_disable_device in case of error Saurabh Sengar
@ 2015-12-14 21:22 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-12-14 21:22 UTC (permalink / raw)
To: saurabh.truth; +Cc: khc, netdev, linux-kernel
From: Saurabh Sengar <saurabh.truth@gmail.com>
Date: Sat, 12 Dec 2015 00:58:19 +0530
> If there is 'no suitable DMA available' error, device should be disabled
> before returning
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-14 21:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-11 19:28 [PATCH] wan: wanxl: add pci_disable_device in case of error Saurabh Sengar
2015-12-14 21:22 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®