[RESEND PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

[RESEND PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

[Saurabh Sengar]

added iounmap inorder to free memory mapped to base before returning

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
 drivers/usb/host/pci-quirks.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
index 26cb8c8..35af362 100644
--- a/drivers/usb/host/pci-quirks.c
+++ b/drivers/usb/host/pci-quirks.c
@@ -992,7 +992,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
 	if ((ext_cap_offset + sizeof(val)) > len) {
 		/* We're reading garbage from the controller */
 		dev_warn(&pdev->dev, "xHCI controller failing to respond");
-		return;
+		goto iounmap;
 	}
 	val = readl(base + ext_cap_offset);
 
@@ -1055,6 +1055,7 @@ hc_init:
 			 XHCI_MAX_HALT_USEC, val);
 	}
 
+iounmap:
 	iounmap(base);
 }
 
-- 
1.9.1

Re: [RESEND PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap

[Greg KH]

On Sun, Dec 13, 2015 at 01:26:17PM +0530, Saurabh Sengar wrote:
> added iounmap inorder to free memory mapped to base before returning
> 
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
>  drivers/usb/host/pci-quirks.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

This is a resend of what version?

And why did you resend it?

I've now dropped all pending versions of this from my queue, please send
your latest one, with all of the proper changelog information (i.e. what
version the patch is, what changed between versions, etc.)  Otherwise
it's impossible for me to know what to do with the patch...

thanks,

greg k-h