* [PATCH] PCI: pciehp: hide ENTRY messages behind ctrl_dbg()
@ 2013-01-28 10:00 Paul Bolle
2013-01-31 17:13 ` Bjorn Helgaas
0 siblings, 1 reply; 5+ messages in thread
From: Paul Bolle @ 2013-01-28 10:00 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: linux-pci, linux-kernel
In each suspend and resume cycle my laptop prints these messages at
KERN_INFO level:
pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY
pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY
and
pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY
pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY
Messages like these are probably only useful while debugging pciehp, so
let's hide them behind the ctrl_dbg() macro.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) Compile tested only!
1) Perhaps a better solution is to drop these messages entirely.
drivers/pci/hotplug/pciehp_core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c
index 939bd1d..ed1702d 100644
--- a/drivers/pci/hotplug/pciehp_core.c
+++ b/drivers/pci/hotplug/pciehp_core.c
@@ -293,7 +293,8 @@ static void pciehp_remove(struct pcie_device *dev)
#ifdef CONFIG_PM
static int pciehp_suspend (struct pcie_device *dev)
{
- dev_info(&dev->device, "%s ENTRY\n", __func__);
+ struct controller *ctrl = get_service_data(dev);
+ ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
return 0;
}
@@ -303,8 +304,8 @@ static int pciehp_resume (struct pcie_device *dev)
struct slot *slot;
u8 status;
- dev_info(&dev->device, "%s ENTRY\n", __func__);
ctrl = get_service_data(dev);
+ ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
/* reinitialize the chipset's event detection logic */
pcie_enable_notification(ctrl);
--
1.7.11.7
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: pciehp: hide ENTRY messages behind ctrl_dbg()
2013-01-28 10:00 [PATCH] PCI: pciehp: hide ENTRY messages behind ctrl_dbg() Paul Bolle
@ 2013-01-31 17:13 ` Bjorn Helgaas
2013-01-31 17:54 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Bjorn Helgaas @ 2013-01-31 17:13 UTC (permalink / raw)
To: Paul Bolle; +Cc: linux-pci, linux-kernel, Rafael J. Wysocki
[+cc Rafael]
On Mon, Jan 28, 2013 at 3:00 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> In each suspend and resume cycle my laptop prints these messages at
> KERN_INFO level:
> pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY
> pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY
>
> and
> pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY
> pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY
>
> Messages like these are probably only useful while debugging pciehp, so
> let's hide them behind the ctrl_dbg() macro.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> 0) Compile tested only!
>
> 1) Perhaps a better solution is to drop these messages entirely.
>
> drivers/pci/hotplug/pciehp_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c
> index 939bd1d..ed1702d 100644
> --- a/drivers/pci/hotplug/pciehp_core.c
> +++ b/drivers/pci/hotplug/pciehp_core.c
> @@ -293,7 +293,8 @@ static void pciehp_remove(struct pcie_device *dev)
> #ifdef CONFIG_PM
> static int pciehp_suspend (struct pcie_device *dev)
> {
> - dev_info(&dev->device, "%s ENTRY\n", __func__);
> + struct controller *ctrl = get_service_data(dev);
> + ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
> return 0;
I'd propose to just drop these messages completely. Rafael, would you
have any objection to that?
> }
>
> @@ -303,8 +304,8 @@ static int pciehp_resume (struct pcie_device *dev)
> struct slot *slot;
> u8 status;
>
> - dev_info(&dev->device, "%s ENTRY\n", __func__);
> ctrl = get_service_data(dev);
> + ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
>
> /* reinitialize the chipset's event detection logic */
> pcie_enable_notification(ctrl);
> --
> 1.7.11.7
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] PCI: pciehp: hide ENTRY messages behind ctrl_dbg()
2013-01-31 17:13 ` Bjorn Helgaas
@ 2013-01-31 17:54 ` Rafael J. Wysocki
2013-01-31 18:35 ` [PATCH v2] PCI: pciehp: drop ENTRY messages Paul Bolle
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2013-01-31 17:54 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Paul Bolle, linux-pci, linux-kernel
On Thursday, January 31, 2013 10:13:17 AM Bjorn Helgaas wrote:
> [+cc Rafael]
>
> On Mon, Jan 28, 2013 at 3:00 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > In each suspend and resume cycle my laptop prints these messages at
> > KERN_INFO level:
> > pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY
> > pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY
> >
> > and
> > pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY
> > pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY
> >
> > Messages like these are probably only useful while debugging pciehp, so
> > let's hide them behind the ctrl_dbg() macro.
> >
> > Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> > ---
> > 0) Compile tested only!
> >
> > 1) Perhaps a better solution is to drop these messages entirely.
> >
> > drivers/pci/hotplug/pciehp_core.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c
> > index 939bd1d..ed1702d 100644
> > --- a/drivers/pci/hotplug/pciehp_core.c
> > +++ b/drivers/pci/hotplug/pciehp_core.c
> > @@ -293,7 +293,8 @@ static void pciehp_remove(struct pcie_device *dev)
> > #ifdef CONFIG_PM
> > static int pciehp_suspend (struct pcie_device *dev)
> > {
> > - dev_info(&dev->device, "%s ENTRY\n", __func__);
> > + struct controller *ctrl = get_service_data(dev);
> > + ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
> > return 0;
>
> I'd propose to just drop these messages completely. Rafael, would you
> have any objection to that?
No, I wouldn't.
>
> > }
> >
> > @@ -303,8 +304,8 @@ static int pciehp_resume (struct pcie_device *dev)
> > struct slot *slot;
> > u8 status;
> >
> > - dev_info(&dev->device, "%s ENTRY\n", __func__);
> > ctrl = get_service_data(dev);
> > + ctrl_dbg(ctrl, "%s ENTRY\n", __func__);
> >
> > /* reinitialize the chipset's event detection logic */
> > pcie_enable_notification(ctrl);
> > --
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH v2] PCI: pciehp: drop ENTRY messages
2013-01-31 17:54 ` Rafael J. Wysocki
@ 2013-01-31 18:35 ` Paul Bolle
2013-02-01 22:57 ` Bjorn Helgaas
0 siblings, 1 reply; 5+ messages in thread
From: Paul Bolle @ 2013-01-31 18:35 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: Rafael J. Wysocki, linux-pci, linux-kernel
In each suspend and resume cycle my laptop prints these messages at
KERN_INFO level:
pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY
pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY
and
pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY
pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY
Drop these messages, that were probably used to debug the suspend and
resume code, but now serve no purpose.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
0) v1 was called "PCI: pciehp: hide ENTRY messages behind ctrl_dbg()".
But Bjorn and Rafael prefer to drop these messages completely.
1) Not even compile tested!
drivers/pci/hotplug/pciehp_core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c
index 939bd1d..7d72c5e 100644
--- a/drivers/pci/hotplug/pciehp_core.c
+++ b/drivers/pci/hotplug/pciehp_core.c
@@ -293,7 +293,6 @@ static void pciehp_remove(struct pcie_device *dev)
#ifdef CONFIG_PM
static int pciehp_suspend (struct pcie_device *dev)
{
- dev_info(&dev->device, "%s ENTRY\n", __func__);
return 0;
}
@@ -303,7 +302,6 @@ static int pciehp_resume (struct pcie_device *dev)
struct slot *slot;
u8 status;
- dev_info(&dev->device, "%s ENTRY\n", __func__);
ctrl = get_service_data(dev);
/* reinitialize the chipset's event detection logic */
--
1.7.11.7
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] PCI: pciehp: drop ENTRY messages
2013-01-31 18:35 ` [PATCH v2] PCI: pciehp: drop ENTRY messages Paul Bolle
@ 2013-02-01 22:57 ` Bjorn Helgaas
0 siblings, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2013-02-01 22:57 UTC (permalink / raw)
To: Paul Bolle; +Cc: Rafael J. Wysocki, linux-pci, linux-kernel
On Thu, Jan 31, 2013 at 11:35 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> In each suspend and resume cycle my laptop prints these messages at
> KERN_INFO level:
> pciehp 0000:00:1c.1:pcie04: pciehp_suspend ENTRY
> pciehp 0000:00:1c.0:pcie04: pciehp_suspend ENTRY
>
> and
> pciehp 0000:00:1c.0:pcie04: pciehp_resume ENTRY
> pciehp 0000:00:1c.1:pcie04: pciehp_resume ENTRY
>
> Drop these messages, that were probably used to debug the suspend and
> resume code, but now serve no purpose.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
I applied this to pci/misc for v3.9. Thanks!
Bjorn
> ---
> 0) v1 was called "PCI: pciehp: hide ENTRY messages behind ctrl_dbg()".
> But Bjorn and Rafael prefer to drop these messages completely.
>
> 1) Not even compile tested!
>
> drivers/pci/hotplug/pciehp_core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/pciehp_core.c b/drivers/pci/hotplug/pciehp_core.c
> index 939bd1d..7d72c5e 100644
> --- a/drivers/pci/hotplug/pciehp_core.c
> +++ b/drivers/pci/hotplug/pciehp_core.c
> @@ -293,7 +293,6 @@ static void pciehp_remove(struct pcie_device *dev)
> #ifdef CONFIG_PM
> static int pciehp_suspend (struct pcie_device *dev)
> {
> - dev_info(&dev->device, "%s ENTRY\n", __func__);
> return 0;
> }
>
> @@ -303,7 +302,6 @@ static int pciehp_resume (struct pcie_device *dev)
> struct slot *slot;
> u8 status;
>
> - dev_info(&dev->device, "%s ENTRY\n", __func__);
> ctrl = get_service_data(dev);
>
> /* reinitialize the chipset's event detection logic */
> --
> 1.7.11.7
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-01 22:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-28 10:00 [PATCH] PCI: pciehp: hide ENTRY messages behind ctrl_dbg() Paul Bolle
2013-01-31 17:13 ` Bjorn Helgaas
2013-01-31 17:54 ` Rafael J. Wysocki
2013-01-31 18:35 ` [PATCH v2] PCI: pciehp: drop ENTRY messages Paul Bolle
2013-02-01 22:57 ` Bjorn Helgaas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®