mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 0/2] m32r: fix build failure
@ 2015-12-22 10:41 Sudip Mukherjee
  2015-12-22 10:41 ` [PATCH 1/2] " Sudip Mukherjee
  2015-12-22 10:42 ` [PATCH 2/2] m32r: add io*_rep helpers Sudip Mukherjee
  0 siblings, 2 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-12-22 10:41 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Sudip Mukherjee

Hi Andrew,

m32r allmodconfig was failing for quite some time.

The first error being:
In file included from ../include/linux/kvm_para.h:4:0,
		 from ../kernel/watchdog.c:26:
../include/uapi/linux/kvm_para.h:30:26: fatal error: asm/kvm_para.h: No such file or directory

patch 1/2 will address this.

After fixing this some more errors surfaced which led to the missing
helpers.

The build still fails for one of the media driver. But atleast with this
series the first few reasons of the failures will be fixed.

Sending to you as m32r architecture is orphan.

Sudip Mukherjee (2):
  m32r: fix build failure
  m32r: add io*_rep helpers

 arch/m32r/include/asm/Kbuild |  1 +
 arch/m32r/include/asm/io.h   | 10 +++++++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

-- 
1.9.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/2] m32r: fix build failure
  2015-12-22 10:41 [PATCH 0/2] m32r: fix build failure Sudip Mukherjee
@ 2015-12-22 10:41 ` Sudip Mukherjee
  2015-12-22 10:42 ` [PATCH 2/2] m32r: add io*_rep helpers Sudip Mukherjee
  1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-12-22 10:41 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Sudip Mukherjee

m32r allmodconfig is failing with:
In file included from ../include/linux/kvm_para.h:4:0,
                 from ../kernel/watchdog.c:26:
../include/uapi/linux/kvm_para.h:30:26: fatal error: asm/kvm_para.h: No such file or directory

The kvm_para.h was not included in the build.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 arch/m32r/include/asm/Kbuild | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/m32r/include/asm/Kbuild b/arch/m32r/include/asm/Kbuild
index fd104bd..860e440 100644
--- a/arch/m32r/include/asm/Kbuild
+++ b/arch/m32r/include/asm/Kbuild
@@ -3,6 +3,7 @@ generic-y += clkdev.h
 generic-y += cputime.h
 generic-y += exec.h
 generic-y += irq_work.h
+generic-y += kvm_para.h
 generic-y += mcs_spinlock.h
 generic-y += mm-arch-hooks.h
 generic-y += module.h
-- 
1.9.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] m32r: add io*_rep helpers
  2015-12-22 10:41 [PATCH 0/2] m32r: fix build failure Sudip Mukherjee
  2015-12-22 10:41 ` [PATCH 1/2] " Sudip Mukherjee
@ 2015-12-22 10:42 ` Sudip Mukherjee
  1 sibling, 0 replies; 3+ messages in thread
From: Sudip Mukherjee @ 2015-12-22 10:42 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Sudip Mukherjee

m32r allmodconfig was failing with the error:
error: implicit declaration of function 'read'

On checking io.h it turned out that 'read' is not defined but 'readb' is
defined and 'ioread8' will then obviously mean 'readb'.

At the same time some of the helper functions ioreadN_rep() and
iowriteN_rep() were missing which also led to the build failure.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

After the change from read to readb the build has been verified with a
defconfig build.

 arch/m32r/include/asm/io.h | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/m32r/include/asm/io.h b/arch/m32r/include/asm/io.h
index 61b8931..4b0f5e0 100644
--- a/arch/m32r/include/asm/io.h
+++ b/arch/m32r/include/asm/io.h
@@ -168,13 +168,21 @@ static inline void _writel(unsigned long l, unsigned long addr)
 #define writew_relaxed writew
 #define writel_relaxed writel
 
-#define ioread8 read
+#define ioread8 readb
 #define ioread16 readw
 #define ioread32 readl
 #define iowrite8 writeb
 #define iowrite16 writew
 #define iowrite32 writel
 
+#define ioread8_rep(p, dst, count) insb((unsigned long)(p), (dst), (count))
+#define ioread16_rep(p, dst, count) insw((unsigned long)(p), (dst), (count))
+#define ioread32_rep(p, dst, count) insl((unsigned long)(p), (dst), (count))
+
+#define iowrite8_rep(p, src, count) outsb((unsigned long)(p), (src), (count))
+#define iowrite16_rep(p, src, count) outsw((unsigned long)(p), (src), (count))
+#define iowrite32_rep(p, src, count) outsl((unsigned long)(p), (src), (count))
+
 #define ioread16be(addr)	be16_to_cpu(readw(addr))
 #define ioread32be(addr)	be32_to_cpu(readl(addr))
 #define iowrite16be(v, addr)	writew(cpu_to_be16(v), (addr))
-- 
1.9.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-22 10:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-22 10:41 [PATCH 0/2] m32r: fix build failure Sudip Mukherjee
2015-12-22 10:41 ` [PATCH 1/2] " Sudip Mukherjee
2015-12-22 10:42 ` [PATCH 2/2] m32r: add io*_rep helpers Sudip Mukherjee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®