mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>
Subject: [PATCH v3 7/9] stm class: Prevent user-controllable allocations
Date: Tue, 22 Dec 2015 17:25:21 +0200	[thread overview]
Message-ID: <1450797923-23072-8-git-send-email-alexander.shishkin@linux.intel.com> (raw)
In-Reply-To: <1450797923-23072-1-git-send-email-alexander.shishkin@linux.intel.com>

Currently, the character device write method allocates a temporary buffer
for user's data, but the user's data size is not sanitized and can cause
arbitrarily large allocations via kzalloc() or an integer overflow that
will then result in overwriting kernel memory.

This patch trims the input buffer size to avoid these issues.

Reported-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 drivers/hwtracing/stm/core.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index 40a8b79ab7..aef8ddb244 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -406,6 +406,9 @@ static ssize_t stm_char_write(struct file *file, const char __user *buf,
 	char *kbuf;
 	int err;
 
+	if (count + 1 > PAGE_SIZE)
+		count = PAGE_SIZE - 1;
+
 	/*
 	 * if no m/c have been assigned to this writer up to this
 	 * point, use "default" policy entry
-- 
2.6.4


  parent reply	other threads:[~2015-12-22 15:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-22 15:25 [PATCH v3 0/9] stm/intel_th: Updates for 4.4 Alexander Shishkin
2015-12-22 15:25 ` [PATCH v3 1/9] stm class: Hide STM-specific options if STM is disabled Alexander Shishkin
2015-12-22 15:25 ` [PATCH v3 2/9] intel_th: INTEL_TH should depend on HAS_DMA Alexander Shishkin
2015-12-22 15:25 ` [PATCH v3 3/9] stm class: Select CONFIG_SRCU Alexander Shishkin
2015-12-22 15:25 ` [PATCH v3 4/9] stm class: Fix locking in unbinding policy path Alexander Shishkin
2015-12-22 15:25 ` [PATCH v3 5/9] stm class: Fix link list locking Alexander Shishkin
2015-12-22 15:25 ` [PATCH v3 6/9] stm class: Fix an off-by-one in master array allocation Alexander Shishkin
2015-12-22 15:25 ` Alexander Shishkin [this message]
2015-12-22 15:25 ` [PATCH v3 8/9] intel_th: pci: Add Apollo Lake SOC support Alexander Shishkin
2015-12-22 15:25 ` [PATCH v3 9/9] intel_th: pci: Add Broxton " Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1450797923-23072-8-git-send-email-alexander.shishkin@linux.intel.com \
    --to=alexander.shishkin@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®