From: Andrzej Hajda <a.hajda@samsung.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-arm-kernel@lists.infradead.org (open list:SYSTEM CONTROL &
POWER INTERFACE (SCPI) Message...),
linux-pm@vger.kernel.org (open list:CPU FREQUENCY DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id
Date: Wed, 23 Dec 2015 11:37:18 +0100 [thread overview]
Message-ID: <1450867041-729-1-git-send-email-a.hajda@samsung.com> (raw)
The function can return negative values, so its result should
be assigned to signed variable.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/cpufreq/scpi-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index 2c3b16f..de5e89b 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -31,7 +31,7 @@ static struct scpi_ops *scpi_ops;
static struct scpi_dvfs_info *scpi_get_dvfs_info(struct device *cpu_dev)
{
- u8 domain = topology_physical_package_id(cpu_dev->id);
+ int domain = topology_physical_package_id(cpu_dev->id);
if (domain < 0)
return ERR_PTR(-EINVAL);
--
1.9.1
next reply other threads:[~2015-12-23 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 10:37 Andrzej Hajda [this message]
2015-12-23 10:37 ` [PATCH] pinctrl: nsp-gpio: fix type of iterator Andrzej Hajda
2015-12-23 22:35 ` Ray Jui
2015-12-24 5:33 ` Yendapally Reddy Dhananjaya Reddy
2015-12-24 9:03 ` Linus Walleij
2015-12-23 10:37 ` [PATCH] NFC: nci: fix handling return value of nci_hci_create_pipe Andrzej Hajda
2015-12-23 10:37 ` [PATCH] ASoC: rsnd: fix usrcnt decrementing bug Andrzej Hajda
2015-12-24 0:04 ` Kuninori Morimoto
2015-12-24 5:56 ` Andrzej Hajda
2015-12-24 6:14 ` Kuninori Morimoto
2015-12-24 7:02 ` [PATCH v2] " Andrzej Hajda
2015-12-24 7:38 ` Kuninori Morimoto
2015-12-30 17:12 ` Mark Brown
2015-12-23 10:41 ` [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id Viresh Kumar
2015-12-23 10:48 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450867041-729-1-git-send-email-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®