From: Andrzej Hajda <a.hajda@samsung.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-gpio@vger.kernel.org (open list:PIN CONTROL SUBSYSTEM),
linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
IPROC ARM ARCHITECTURE),
bcm-kernel-feedback-list@broadcom.com (open list:BROADCOM IPROC
ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] pinctrl: nsp-gpio: fix type of iterator
Date: Wed, 23 Dec 2015 11:37:19 +0100 [thread overview]
Message-ID: <1450867041-729-2-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1450867041-729-1-git-send-email-a.hajda@samsung.com>
Iterator i declared as unsigned is always non-negative so the
loop will never end.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/pinctrl/bcm/pinctrl-nsp-gpio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
index 34648f6..ad5b04c 100644
--- a/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-nsp-gpio.c
@@ -439,7 +439,8 @@ static int nsp_gpio_set_strength(struct nsp_gpio *chip, unsigned gpio,
static int nsp_gpio_get_strength(struct nsp_gpio *chip, unsigned gpio,
u16 *strength)
{
- unsigned int i, offset, shift;
+ unsigned int offset, shift;
+ int i;
u32 val;
unsigned long flags;
--
1.9.1
next prev parent reply other threads:[~2015-12-23 10:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 10:37 [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id Andrzej Hajda
2015-12-23 10:37 ` Andrzej Hajda [this message]
2015-12-23 22:35 ` [PATCH] pinctrl: nsp-gpio: fix type of iterator Ray Jui
2015-12-24 5:33 ` Yendapally Reddy Dhananjaya Reddy
2015-12-24 9:03 ` Linus Walleij
2015-12-23 10:37 ` [PATCH] NFC: nci: fix handling return value of nci_hci_create_pipe Andrzej Hajda
2015-12-23 10:37 ` [PATCH] ASoC: rsnd: fix usrcnt decrementing bug Andrzej Hajda
2015-12-24 0:04 ` Kuninori Morimoto
2015-12-24 5:56 ` Andrzej Hajda
2015-12-24 6:14 ` Kuninori Morimoto
2015-12-24 7:02 ` [PATCH v2] " Andrzej Hajda
2015-12-24 7:38 ` Kuninori Morimoto
2015-12-30 17:12 ` Mark Brown
2015-12-23 10:41 ` [PATCH] cpufreq/scpi: fix handling return value of topology_physical_package_id Viresh Kumar
2015-12-23 10:48 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450867041-729-2-git-send-email-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jonmason@broadcom.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®