From: Andrzej Hajda <a.hajda@samsung.com>
To: "James E.J. Bottomley" <JBottomley@odin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-scsi@vger.kernel.org (open list:SCSI SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] scsi_transport_fc: remove useless check
Date: Wed, 30 Dec 2015 12:18:44 +0100 [thread overview]
Message-ID: <1451474324-15481-3-git-send-email-a.hajda@samsung.com> (raw)
In-Reply-To: <1451474324-15481-1-git-send-email-a.hajda@samsung.com>
simple_strtoul returns only non-negative values and *val is unsigned
so there is no possibility that *val is lesser than 0.
The problem has been detected using proposed semantic patch
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
[1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
---
drivers/scsi/scsi_transport_fc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c
index 8a88226..ecf62d9 100644
--- a/drivers/scsi/scsi_transport_fc.c
+++ b/drivers/scsi/scsi_transport_fc.c
@@ -849,7 +849,7 @@ static int fc_str_to_dev_loss(const char *buf, unsigned long *val)
char *cp;
*val = simple_strtoul(buf, &cp, 0);
- if ((*cp && (*cp != '\n')) || (*val < 0))
+ if (*cp && (*cp != '\n'))
return -EINVAL;
/*
* Check for overflow; dev_loss_tmo is u32
--
1.9.1
next prev parent reply other threads:[~2015-12-30 11:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-30 11:18 [PATCH] cpufreq-dt: fix handling regulator_get_voltage result Andrzej Hajda
2015-12-30 11:18 ` [PATCH] staging: lustre: remove useless check Andrzej Hajda
2015-12-30 11:18 ` Andrzej Hajda [this message]
2016-01-04 5:28 ` [PATCH] cpufreq-dt: fix handling regulator_get_voltage result Viresh Kumar
2016-01-05 13:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451474324-15481-3-git-send-email-a.hajda@samsung.com \
--to=a.hajda@samsung.com \
--cc=JBottomley@odin.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®