From: Jiri Olsa <jolsa@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Noel Grandin <noelgrandin@gmail.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: [PATCH 02/13] perf tools: Make perf_evlist__open() open evsels with their cpus and threads (like perf record does)
Date: Thu, 7 Jan 2016 10:13:59 +0100 [thread overview]
Message-ID: <1452158050-28061-3-git-send-email-jolsa@kernel.org> (raw)
In-Reply-To: <1452158050-28061-1-git-send-email-jolsa@kernel.org>
From: Adrian Hunter <adrian.hunter@intel.com>
'perf record' uses perf_evsel__open() to open events and passes the evsel->cpus
and evsel->threads. Many tests and some tools instead use perf_evlist__open()
which passes instead evlist->cpus and evlist->threads.
Make perf_evlist__open() follow the 'perf record' behaviour so that a consistent
approach is taken.
Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---
tools/perf/util/evlist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 05efa910a090..43f4c400a171 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -1428,7 +1428,7 @@ int perf_evlist__open(struct perf_evlist *evlist)
perf_evlist__update_id_pos(evlist);
evlist__for_each(evlist, evsel) {
- err = perf_evsel__open(evsel, evlist->cpus, evlist->threads);
+ err = perf_evsel__open(evsel, evsel->cpus, evsel->threads);
if (err < 0)
goto out_err;
}
--
2.4.3
next prev parent reply other threads:[~2016-01-07 9:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 9:13 [PATCHv2 00/13] perf tools: Various fixes Jiri Olsa
2016-01-07 9:13 ` [PATCH 01/13] perf tools: Remove perf_evlist__(enable|disable)_event functions Jiri Olsa
2016-01-09 16:40 ` [tip:perf/core] perf evlist: Remove perf_evlist__(enable|disable) _event functions tip-bot for Jiri Olsa
2016-01-07 9:13 ` Jiri Olsa [this message]
2016-01-09 16:40 ` [tip:perf/core] perf evlist: Make perf_evlist__open() open evsels with their cpus and threads (like perf record does) tip-bot for Adrian Hunter
2016-01-07 9:14 ` [PATCH 03/13] perf tools: Use find_map function in access_dso_mem Jiri Olsa
2016-01-09 16:41 ` [tip:perf/core] perf unwind: " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 04/13] perf tools libunwind: Check for mmaps also in MAP__VARIABLE tree Jiri Olsa
2016-01-09 16:41 ` [tip:perf/core] perf unwind: " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 05/13] perf tools libdw: " Jiri Olsa
2016-01-09 16:41 ` [tip:perf/core] perf " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 06/13] perf record: Store data mmaps for dwarf unwind Jiri Olsa
2016-01-07 11:12 ` Namhyung Kim
2016-01-07 12:39 ` [PATCHv2 " Jiri Olsa
2016-01-07 13:14 ` Namhyung Kim
2016-01-07 13:30 ` [PATCHv3 " Jiri Olsa
2016-01-07 20:42 ` Arnaldo Carvalho de Melo
2016-01-09 16:42 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 07/13] perf tools: Do not show trace command if it's not compiled in Jiri Olsa
2016-01-09 16:37 ` [tip:perf/core] perf tools: Do not show trace command if it' s " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 08/13] perf script: Align event name properly Jiri Olsa
2016-01-09 16:38 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 09/13] perf tools: Include all tools/lib directory for tags/cscope/TAGS targets Jiri Olsa
2016-01-09 16:38 ` [tip:perf/core] perf tools: Include all tools/ lib " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 10/13] perf tools: Remove list entry from struct sort_entry Jiri Olsa
2016-01-07 11:13 ` Namhyung Kim
2016-01-09 16:38 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 11/13] perf tools: Add overhead/overhead_children keys defaults via string Jiri Olsa
2016-01-07 11:17 ` Namhyung Kim
2016-01-09 16:39 ` [tip:perf/core] perf tools: Add overhead/ overhead_children " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 12/13] perf diff: Use perf_hpp__register_sort_field interface Jiri Olsa
2016-01-07 11:17 ` Namhyung Kim
2016-01-09 16:39 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 13/13] perf tools: Export a couple of hist functions Jiri Olsa
2016-01-09 16:39 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452158050-28061-3-git-send-email-jolsa@kernel.org \
--to=jolsa@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=noelgrandin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome