From: tip-bot for Jiri Olsa <tipbot@zytor.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jolsa@kernel.org,
namhyung@kernel.org, mingo@kernel.org, acme@redhat.com,
a.p.zijlstra@chello.nl, tglx@linutronix.de, dsahern@gmail.com,
noelgrandin@gmail.com, hpa@zytor.com, adrian.hunter@intel.com,
jolsa@redhat.com
Subject: [tip:perf/core] perf record: Store data mmaps for dwarf unwind
Date: Sat, 9 Jan 2016 08:42:21 -0800 [thread overview]
Message-ID: <tip-5c0cf22477eaa890beeb4bc3554e5bebbea4b007@git.kernel.org> (raw)
In-Reply-To: <20160107133022.GA32115@krava.brq.redhat.com>
Commit-ID: 5c0cf22477eaa890beeb4bc3554e5bebbea4b007
Gitweb: http://git.kernel.org/tip/5c0cf22477eaa890beeb4bc3554e5bebbea4b007
Author: Jiri Olsa <jolsa@redhat.com>
AuthorDate: Thu, 7 Jan 2016 14:30:22 +0100
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 8 Jan 2016 14:17:45 -0300
perf record: Store data mmaps for dwarf unwind
Currently we don't synthesize data mmap by default. It depends on -d
option, that enables data address sampling.
But we've seen cases (softice) where DWARF unwinder went through non
executable mmaps, which we need to lookup in MAP__VARIABLE tree.
Making data mmaps to be synthesized for dwarf unwind as well.
Reported-by: Noel Grandin <noelgrandin@gmail.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/20160107133022.GA32115@krava.brq.redhat.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/builtin-record.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 9c5cdc2c4..dc4e0ad 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -815,8 +815,12 @@ int record_parse_callchain_opt(const struct option *opt,
}
ret = parse_callchain_record_opt(arg, &callchain_param);
- if (!ret)
+ if (!ret) {
+ /* Enable data address sampling for DWARF unwind. */
+ if (callchain_param.record_mode == CALLCHAIN_DWARF)
+ record->sample_address = true;
callchain_debug();
+ }
return ret;
}
next prev parent reply other threads:[~2016-01-09 16:42 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 9:13 [PATCHv2 00/13] perf tools: Various fixes Jiri Olsa
2016-01-07 9:13 ` [PATCH 01/13] perf tools: Remove perf_evlist__(enable|disable)_event functions Jiri Olsa
2016-01-09 16:40 ` [tip:perf/core] perf evlist: Remove perf_evlist__(enable|disable) _event functions tip-bot for Jiri Olsa
2016-01-07 9:13 ` [PATCH 02/13] perf tools: Make perf_evlist__open() open evsels with their cpus and threads (like perf record does) Jiri Olsa
2016-01-09 16:40 ` [tip:perf/core] perf evlist: " tip-bot for Adrian Hunter
2016-01-07 9:14 ` [PATCH 03/13] perf tools: Use find_map function in access_dso_mem Jiri Olsa
2016-01-09 16:41 ` [tip:perf/core] perf unwind: " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 04/13] perf tools libunwind: Check for mmaps also in MAP__VARIABLE tree Jiri Olsa
2016-01-09 16:41 ` [tip:perf/core] perf unwind: " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 05/13] perf tools libdw: " Jiri Olsa
2016-01-09 16:41 ` [tip:perf/core] perf " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 06/13] perf record: Store data mmaps for dwarf unwind Jiri Olsa
2016-01-07 11:12 ` Namhyung Kim
2016-01-07 12:39 ` [PATCHv2 " Jiri Olsa
2016-01-07 13:14 ` Namhyung Kim
2016-01-07 13:30 ` [PATCHv3 " Jiri Olsa
2016-01-07 20:42 ` Arnaldo Carvalho de Melo
2016-01-09 16:42 ` tip-bot for Jiri Olsa [this message]
2016-01-07 9:14 ` [PATCH 07/13] perf tools: Do not show trace command if it's not compiled in Jiri Olsa
2016-01-09 16:37 ` [tip:perf/core] perf tools: Do not show trace command if it' s " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 08/13] perf script: Align event name properly Jiri Olsa
2016-01-09 16:38 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 09/13] perf tools: Include all tools/lib directory for tags/cscope/TAGS targets Jiri Olsa
2016-01-09 16:38 ` [tip:perf/core] perf tools: Include all tools/ lib " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 10/13] perf tools: Remove list entry from struct sort_entry Jiri Olsa
2016-01-07 11:13 ` Namhyung Kim
2016-01-09 16:38 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 11/13] perf tools: Add overhead/overhead_children keys defaults via string Jiri Olsa
2016-01-07 11:17 ` Namhyung Kim
2016-01-09 16:39 ` [tip:perf/core] perf tools: Add overhead/ overhead_children " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 12/13] perf diff: Use perf_hpp__register_sort_field interface Jiri Olsa
2016-01-07 11:17 ` Namhyung Kim
2016-01-09 16:39 ` [tip:perf/core] " tip-bot for Jiri Olsa
2016-01-07 9:14 ` [PATCH 13/13] perf tools: Export a couple of hist functions Jiri Olsa
2016-01-09 16:39 ` [tip:perf/core] perf hists: " tip-bot for Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tip-5c0cf22477eaa890beeb4bc3554e5bebbea4b007@git.kernel.org \
--to=tipbot@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=noelgrandin@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome