From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "ynezz@true.cz" <ynezz@true.cz>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"stefan@agner.ch" <stefan@agner.ch>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"stillcompiling@gmail.com" <stillcompiling@gmail.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM
Date: Fri, 8 Jan 2016 10:59:32 +0000 [thread overview]
Message-ID: <1452250771.3357.26.camel@toradex.com> (raw)
In-Reply-To: <20160108085734.GC27359@ibawizard.net>
On Fri, 2016-01-08 at 09:57 +0100, Petr Štetiar wrote:
> > + i2cddc: i2c@0 {
> > + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */
> > + &gpio2 30 GPIO_ACTIVE_HIGH /* scl */
> > + >;
>
> According to one of the comments, it should be changed to the
> following:
>
> sda-gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
No, I believe you mixed the i2c-imx binding with the i2c-gpio one [2].
> -- ynezz
[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/i2c/i2c-imx.txt
[2] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/i2c/i2c-gpio.txt
Cheers
Marcel
next prev parent reply other threads:[~2016-01-08 11:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 16:39 [PATCH v2 0/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM/Ixora carrier board Marcel Ziswiler
2016-01-05 16:39 ` [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Marcel Ziswiler
2016-01-06 8:03 ` Petr Štetiar
2016-01-06 9:15 ` Marcel Ziswiler
2016-01-08 8:42 ` Petr Štetiar
2016-01-08 10:59 ` Marcel Ziswiler
2016-01-07 6:29 ` Stefan Agner
2016-01-08 8:28 ` Marcel Ziswiler
2016-01-08 8:57 ` Petr Štetiar
2016-01-08 10:59 ` Marcel Ziswiler [this message]
2016-01-05 16:39 ` [PATCH v2 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board Marcel Ziswiler
2016-01-07 6:38 ` Stefan Agner
2016-01-08 8:29 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452250771.3357.26.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
--cc=stillcompiling@gmail.com \
--cc=ynezz@true.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome