mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Petr Štetiar" <ynezz@true.cz>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: linux-arm-kernel@lists.infradead.org,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Petr Štetiar" <ynezz@true.cz>,
	"Shawn Guo" <shawn.guo@linaro.org>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Stefan Agner" <stefan@agner.ch>,
	"Joshua Clayton" <stillcompiling@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM
Date: Fri, 8 Jan 2016 09:57:34 +0100	[thread overview]
Message-ID: <20160108085734.GC27359@ibawizard.net> (raw)
In-Reply-To: <1452011942-11940-2-git-send-email-marcel.ziswiler@toradex.com>

> +	i2cddc: i2c@0 {
> +		gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */
> +			 &gpio2 30 GPIO_ACTIVE_HIGH /* scl */
> +			>;

According to one of the comments, it should be changed to the following:

		sda-gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
		scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;

-- ynezz

  parent reply	other threads:[~2016-01-08  8:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05 16:39 [PATCH v2 0/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM/Ixora carrier board Marcel Ziswiler
2016-01-05 16:39 ` [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Marcel Ziswiler
2016-01-06  8:03   ` Petr Štetiar
2016-01-06  9:15     ` Marcel Ziswiler
2016-01-08  8:42       ` Petr Štetiar
2016-01-08 10:59         ` Marcel Ziswiler
2016-01-07  6:29   ` Stefan Agner
2016-01-08  8:28     ` Marcel Ziswiler
2016-01-08  8:57   ` Petr Štetiar [this message]
2016-01-08 10:59     ` Marcel Ziswiler
2016-01-05 16:39 ` [PATCH v2 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board Marcel Ziswiler
2016-01-07  6:38   ` Stefan Agner
2016-01-08  8:29     ` Marcel Ziswiler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160108085734.GC27359@ibawizard.net \
    --to=ynezz@true.cz \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marcel.ziswiler@toradex.com \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=shawnguo@kernel.org \
    --cc=stefan@agner.ch \
    --cc=stillcompiling@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome