From: "Nicholas A. Bellinger" <nab@daterainc.com>
To: target-devel <target-devel@vger.kernel.org>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Sagi Grimberg <sagig@mellanox.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Andy Grover <agrover@redhat.com>,
Vasu Dev <vasu.dev@linux.intel.com>, Vu Pham <vu@mellanox.com>,
Nicholas Bellinger <nab@linux-iscsi.org>
Subject: [PATCH-v2 0/4] target: Close se_node_acl lookup race
Date: Sun, 10 Jan 2016 20:28:40 +0000 [thread overview]
Message-ID: <1452457724-10629-1-git-send-email-nab@daterainc.com> (raw)
From: Nicholas Bellinger <nab@linux-iscsi.org>
Hi folks,
This -v2 series addresses a long standing race between
fabric driver se_node_acl lookup + pointer dereference
during session login, and when kref_get() of ->acl_kref
actually happens within __transport_register_session()
code.
Also as reported earlier by HCH, go ahead and convert
core_tpg_set_initiator_node_queue_depth() to use proper
se_node_acl->se_acl_list -> se_session dereference,
following how core_tpg_del_initiator_node_acl() works
for invoking explicit session shutdown.
Please review,
--nab
-v2 changes:
- Have tcm_fc/ib_srpt conversion preceed other changes
- Fix demo-mode acl regression with generate_node_acls=1
- Fix set_initiator_node_queue_depth session reference
usage.
- Add ib_srpt hack to avoid potential user-space
backwards-compat issue.
Nicholas Bellinger (4):
tcm_fc: Convert acl lookup to modern get_initiator_node_acl usage
ib_srpt: Convert acl lookup to modern get_initiator_node_acl usage
target: Fix change depth se_session reference usage
target: Obtain se_node_acl->acl_kref during get_initiator_node_acl
drivers/infiniband/ulp/srpt/ib_srpt.c | 95 +++++-----------
drivers/infiniband/ulp/srpt/ib_srpt.h | 2 -
drivers/target/iscsi/iscsi_target_configfs.c | 14 ++-
drivers/target/iscsi/iscsi_target_tpg.c | 10 --
drivers/target/iscsi/iscsi_target_tpg.h | 2 -
drivers/target/target_core_tpg.c | 161 +++++++++++----------------
drivers/target/target_core_transport.c | 22 ++--
drivers/target/tcm_fc/tfc_conf.c | 26 ++---
drivers/target/tcm_fc/tfc_sess.c | 18 +--
include/target/target_core_fabric.h | 4 +-
10 files changed, 137 insertions(+), 217 deletions(-)
--
1.9.1
next reply other threads:[~2016-01-10 20:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 20:28 Nicholas A. Bellinger [this message]
2016-01-10 20:28 ` [PATCH-v2 1/4] tcm_fc: Convert acl lookup to modern get_initiator_node_acl usage Nicholas A. Bellinger
2016-01-11 21:05 ` Bart Van Assche
2016-01-12 15:02 ` Christoph Hellwig
2016-01-13 7:19 ` Nicholas A. Bellinger
2016-01-10 20:28 ` [PATCH-v2 2/4] ib_srpt: " Nicholas A. Bellinger
2016-01-11 21:34 ` Bart Van Assche
2016-01-13 16:39 ` Sagi Grimberg
2016-01-10 20:28 ` [PATCH-v2 3/4] target: Fix change depth se_session reference usage Nicholas A. Bellinger
2016-01-12 15:07 ` Christoph Hellwig
2016-01-13 7:29 ` Nicholas A. Bellinger
2016-01-13 8:24 ` Christoph Hellwig
2016-01-13 8:56 ` Nicholas A. Bellinger
2016-01-13 8:27 ` Christoph Hellwig
2016-01-13 8:58 ` Nicholas A. Bellinger
2016-01-13 16:45 ` Sagi Grimberg
2016-01-10 20:28 ` [PATCH-v2 4/4] target: Obtain se_node_acl->acl_kref during get_initiator_node_acl Nicholas A. Bellinger
2016-01-12 15:09 ` Christoph Hellwig
2016-01-13 8:00 ` Nicholas A. Bellinger
2016-01-13 8:15 ` Christoph Hellwig
2016-01-13 8:38 ` Nicholas A. Bellinger
2016-01-13 8:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452457724-10629-1-git-send-email-nab@daterainc.com \
--to=nab@daterainc.com \
--cc=agrover@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=sagig@mellanox.com \
--cc=target-devel@vger.kernel.org \
--cc=vasu.dev@linux.intel.com \
--cc=vu@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®