mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rongrong Zou <zourongrong@gmail.com>,
	arnd@arndb.de, catalin.marinas@arm.com, will.deacon@arm.com
Cc: lijianhua@huawei.com, lixiancai@huawei.com, linuxarm@huawei.com,
	linux-kernel@vger.kernel.org, minyard@acm.org,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH v1 3/3] ARM64 LPC: update binding doc
Date: Thu, 14 Jan 2016 22:25:55 +1100	[thread overview]
Message-ID: <1452770755.31558.13.camel@kernel.crashing.org> (raw)
In-Reply-To: <5697274C.1000606@gmail.com>

On Thu, 2016-01-14 at 12:42 +0800, Rongrong Zou wrote:

> > Right, and the "compatible" property should be something like the
> > specific implementation of the LPC bridge. For example, ibm,power8-
> > lpc
> > in my case. Not something generic.
> > 
> > Maybe we could allow for a generic one if the LPC is directly MMIO
> > mapped via the ranges property.
> 
> It is not directly MMIO mapped actually.

I know yours is not. But some are. My point is that we should have a
binding that is either completely specific to your ARM64 LPC or we
should have a generic LPC binding with provisions for implementation
specific stuff such as ARM64 or POWER8 which are both not MMIO mapped.

I go for the latter.

So "ranges" if you are mapped, otherwise "reg", and in the latter case,
the compatible property should be much more specific like it is for P8,

  .../...

> The big problem is we do not want the "ranges" property, but we can't
> get resource if the property is absent, you could see discussion at
> https://lkml.org/lkml/2016/1/11/631.

That's fixable. I missed the discussion but I'll have a look tomorrow.

Cheers
Ben.

  reply	other threads:[~2016-01-14 11:27 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-29 13:33 [PATCH v1 0/3] ARM64 LPC: legacy ISA I/O support Rongrong Zou
2015-12-29 13:33 ` [PATCH v1 1/3] ARM64 LPC: indirect ISA PORT IO introduced Rongrong Zou
2015-12-29 13:47   ` Arnd Bergmann
2015-12-29 14:26     ` Rongrong Zou
2015-12-29 14:35       ` Arnd Bergmann
2015-12-30  1:24         ` Rongrong Zou
2015-12-30  8:59           ` Arnd Bergmann
2015-12-30  9:28             ` Rongrong Zou
2015-12-30  9:42               ` Arnd Bergmann
2016-01-04 10:11                 ` Will Deacon
2016-01-04 10:27                   ` Rongrong Zou
2015-12-29 13:33 ` [PATCH v1 2/3] ARM64 LPC: LPC driver implementation Rongrong Zou
2015-12-29 13:51   ` Arnd Bergmann
2015-12-29 14:03     ` Rongrong Zou
2015-12-29 14:11       ` Arnd Bergmann
2015-12-29 13:33 ` [PATCH v1 3/3] ARM64 LPC: update binding doc Rongrong Zou
2015-12-29 13:52   ` Arnd Bergmann
2015-12-30  9:06   ` Arnd Bergmann
2015-12-31 14:12     ` Rongrong Zou
2015-12-31 14:40       ` Arnd Bergmann
     [not found]         ` <CABTftiT1+AmrNjiAie-T6on-oWA4Zz73+Tj2pQrixMT3o475uw@mail.gmail.com>
2016-01-03 12:24           ` Rongrong Zou
2016-01-04 11:13             ` Arnd Bergmann
2016-01-04 16:04               ` Rongrong Zou
2016-01-04 16:34                 ` Arnd Bergmann
2016-01-05 11:59                   ` Rongrong Zou
2016-01-05 12:19                     ` Arnd Bergmann
2016-01-06 13:36                       ` Rongrong Zou
2016-01-07  3:37                         ` Rongrong Zou
2016-01-10  9:29                       ` Rolland Chau
2016-01-10 13:38                         ` Rongrong Zou
2016-01-11 16:14               ` liviu.dudau
2016-01-12  2:39                 ` Rongrong Zou
2016-01-12  9:07                   ` liviu.dudau
2016-01-12  9:25                     ` Rongrong Zou
2016-01-12 10:14                       ` liviu.dudau
2016-01-12 11:05                         ` Rongrong Zou
2016-01-12 11:27                           ` liviu.dudau
2016-01-12 11:56                             ` Rongrong Zou
2016-01-12 15:13                               ` liviu.dudau
2016-01-12 22:52                                 ` Arnd Bergmann
2016-01-13  5:53                                   ` Benjamin Herrenschmidt
2016-01-13  6:34                                     ` Rongrong Zou
2016-01-13  9:26                                       ` Arnd Bergmann
2016-01-13 10:10                                   ` liviu.dudau
2016-01-13 10:18                                     ` Arnd Bergmann
2016-01-13 10:32                                       ` liviu.dudau
2016-01-12 22:54                         ` Arnd Bergmann
2016-01-13 10:09                           ` liviu.dudau
2016-01-13 10:29                             ` Arnd Bergmann
2016-01-13 11:06                             ` Rongrong Zou
2016-01-13 11:25                               ` liviu.dudau
2016-01-13 23:29   ` Benjamin Herrenschmidt
2016-01-14  2:03     ` Rongrong Zou
2016-01-14  3:39       ` Benjamin Herrenschmidt
2016-01-14  4:42         ` Rongrong Zou
2016-01-14 11:25           ` Benjamin Herrenschmidt [this message]
2016-01-14 13:11             ` Rongrong Zou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452770755.31558.13.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=lijianhua@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=lixiancai@huawei.com \
    --cc=minyard@acm.org \
    --cc=will.deacon@arm.com \
    --cc=zourongrong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome