* [PATCH v2] xen: fix potential integer overflow in queue_reply
@ 2016-01-18 16:54 Insu Yun
0 siblings, 0 replies; only message in thread
From: Insu Yun @ 2016-01-18 16:54 UTC (permalink / raw)
To: konrad.wilk, boris.ostrovsky, david.vrabel, Jennifer.Herbert,
xen-devel, linux-kernel
Cc: taesoo, yeongjin.jang, insu, changwoo, Insu Yun
When len is greater than UINT_MAX - sizeof(*rb), in next allocation,
it can overflow integer range and allocates small size of heap.
After that, memcpy will overflow the allocated heap.
Therefore, it needs to check the size of given length.
Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
drivers/xen/xenbus/xenbus_dev_frontend.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen/xenbus/xenbus_dev_frontend.c
index 9433e46..912b64e 100644
--- a/drivers/xen/xenbus/xenbus_dev_frontend.c
+++ b/drivers/xen/xenbus/xenbus_dev_frontend.c
@@ -188,6 +188,8 @@ static int queue_reply(struct list_head *queue, const void *data, size_t len)
if (len == 0)
return 0;
+ if (len > XENSTORE_PAYLOAD_MAX)
+ return -EINVAL;
rb = kmalloc(sizeof(*rb) + len, GFP_KERNEL);
if (rb == NULL)
--
1.9.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-01-18 16:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-18 16:54 [PATCH v2] xen: fix potential integer overflow in queue_reply Insu Yun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®