From: Philipp Zabel <p.zabel@pengutronix.de>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Chen Feng <puck.chen@hisilicon.com>
Subject: Re: [PATCH] reset: hisilicon: check return value of reset_controller_register()
Date: Mon, 25 Jan 2016 11:01:20 +0100 [thread overview]
Message-ID: <1453716080.2559.3.camel@pengutronix.de> (raw)
In-Reply-To: <1453565997-1010-1-git-send-email-yamada.masahiro@socionext.com>
Am Sonntag, den 24.01.2016, 01:19 +0900 schrieb Masahiro Yamada:
> The newly added hisilicon reset driver missed the subsystem-wide
> fixup by commit d1f15aa09558 ("reset: check return value of
> reset_controller_register()"). So fix it now.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/reset/hisilicon/hi6220_reset.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 7787a9b..744b2e7 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -83,9 +83,7 @@ static int hi6220_reset_probe(struct platform_device *pdev)
> data->rc_dev.ops = &hi6220_reset_ops;
> data->rc_dev.of_node = pdev->dev.of_node;
>
> - reset_controller_register(&data->rc_dev);
> -
> - return 0;
> + return reset_controller_register(&data->rc_dev);
> }
>
> static const struct of_device_id hi6220_reset_match[] = {
Applied, thanks.
regards
Philipp
prev parent reply other threads:[~2016-01-25 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 16:19 Masahiro Yamada
2016-01-25 10:01 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453716080.2559.3.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome