mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] stm: add proper dependencies on the subsystem
Date: Mon, 25 Jan 2016 16:59:30 +0100	[thread overview]
Message-ID: <1453737579-1960217-1-git-send-email-arnd@arndb.de> (raw)

As several people have pointed out, the Kconfig dependencies for
stm are confusing, because you can enable the individual features
even when the subsystem itself is disabled.

It turns out that randconfig tests even show the a build-time
bug because of this:

drivers/hwtracing/stm/built-in.o: In function `dummy_stm_init':
drivers/hwtracing/stm/dummy_stm.c:53: undefined reference to `stm_register_device'
drivers/hwtracing/stm/built-in.o: In function `dummy_stm_exit':
drivers/hwtracing/stm/dummy_stm.c:58: undefined reference to `stm_unregister_device'
drivers/hwtracing/stm/built-in.o:(.debug_addr+0x14): undefined reference to `stm_register_device'
drivers/hwtracing/stm/built-in.o:(.debug_addr+0x1c): undefined reference to `stm_unregister_device'

This adds the missing 'depends on STM' lines.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 2c41538191e1 ("stm class: dummy_stm: Add dummy driver for testing stm class")
---
 drivers/hwtracing/stm/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index 83e9f591a54b..7780be86d913 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -10,6 +10,7 @@ config STM
 
 config STM_DUMMY
 	tristate "Dummy STM driver"
+	depends on STM
 	help
 	  This is a simple dummy device that pretends to be an stm device
 	  and discards your data. Use for stm class testing.
@@ -18,6 +19,7 @@ config STM_DUMMY
 
 config STM_SOURCE_CONSOLE
 	tristate "Kernel console over STM devices"
+	depends on STM
 	help
 	  This is a kernel space trace source that sends kernel log
 	  messages to trace hosts over STM devices.
-- 
2.7.0

             reply	other threads:[~2016-01-25 16:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 15:59 Arnd Bergmann [this message]
2016-01-25 16:17 ` Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453737579-1960217-1-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®