mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] stm: add proper dependencies on the subsystem
Date: Mon, 25 Jan 2016 18:17:58 +0200	[thread overview]
Message-ID: <871t95hbux.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <1453737579-1960217-1-git-send-email-arnd@arndb.de>

Arnd Bergmann <arnd@arndb.de> writes:

> As several people have pointed out, the Kconfig dependencies for
> stm are confusing, because you can enable the individual features
> even when the subsystem itself is disabled.
>
> It turns out that randconfig tests even show the a build-time
> bug because of this:
>
> drivers/hwtracing/stm/built-in.o: In function `dummy_stm_init':
> drivers/hwtracing/stm/dummy_stm.c:53: undefined reference to `stm_register_device'
> drivers/hwtracing/stm/built-in.o: In function `dummy_stm_exit':
> drivers/hwtracing/stm/dummy_stm.c:58: undefined reference to `stm_unregister_device'
> drivers/hwtracing/stm/built-in.o:(.debug_addr+0x14): undefined reference to `stm_register_device'
> drivers/hwtracing/stm/built-in.o:(.debug_addr+0x1c): undefined reference to `stm_unregister_device'
>
> This adds the missing 'depends on STM' lines.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 2c41538191e1 ("stm class: dummy_stm: Add dummy driver for testing stm class")

http://marc.info/?l=linux-kernel&m=144680658616967

Unfortunately I wasn't able to get any fixes in 4.4 or anywhere else so
far.

Thanks,
--
Alex

      reply	other threads:[~2016-01-25 16:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 15:59 Arnd Bergmann
2016-01-25 16:17 ` Alexander Shishkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871t95hbux.fsf@ashishki-desk.ger.corp.intel.com \
    --to=alexander.shishkin@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®