* [PATCH] crypto: hash - select CRYPTO_HASH where needed
@ 2016-01-25 16:51 Arnd Bergmann
2016-01-26 14:48 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-01-25 16:51 UTC (permalink / raw)
To: Herbert Xu
Cc: linux-arm-kernel, Arnd Bergmann, linux-crypto, David S. Miller,
linux-kernel
The ghash and poly1305 hash implementations can be enabled when
CONFIG_CRYPTO_HASH is turned off, causing a link error:
crypto/built-in.o: In function `ghash_mod_init':
(.init.text+0xd0): undefined reference to `crypto_register_shash'
crypto/built-in.o: In function `ghash_mod_exit':
(.exit.text+0xb4): undefined reference to `crypto_unregister_shash'
crypto/built-in.o: In function `poly1305_mod_init':
(.init.text+0xb4): undefined reference to `crypto_register_shash'
crypto/built-in.o: In function `poly1305_mod_exit':
(.exit.text+0x98): undefined reference to `crypto_unregister_shash'
This adds an explicit 'select', like all other hashes have it.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
crypto/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/crypto/Kconfig b/crypto/Kconfig
index 99109b93604a..2d76676a1253 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -472,11 +472,13 @@ config CRYPTO_CRCT10DIF_PCLMUL
config CRYPTO_GHASH
tristate "GHASH digest algorithm"
select CRYPTO_GF128MUL
+ select CRYPTO_HASH
help
GHASH is message digest algorithm for GCM (Galois/Counter Mode).
config CRYPTO_POLY1305
tristate "Poly1305 authenticator algorithm"
+ select CRYPTO_HASH
help
Poly1305 authenticator algorithm, RFC7539.
--
2.7.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: hash - select CRYPTO_HASH where needed
2016-01-25 16:51 [PATCH] crypto: hash - select CRYPTO_HASH where needed Arnd Bergmann
@ 2016-01-26 14:48 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2016-01-26 14:48 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, linux-crypto, David S. Miller, linux-kernel
On Mon, Jan 25, 2016 at 05:51:21PM +0100, Arnd Bergmann wrote:
> The ghash and poly1305 hash implementations can be enabled when
> CONFIG_CRYPTO_HASH is turned off, causing a link error:
>
> crypto/built-in.o: In function `ghash_mod_init':
> (.init.text+0xd0): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `ghash_mod_exit':
> (.exit.text+0xb4): undefined reference to `crypto_unregister_shash'
> crypto/built-in.o: In function `poly1305_mod_init':
> (.init.text+0xb4): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `poly1305_mod_exit':
> (.exit.text+0x98): undefined reference to `crypto_unregister_shash'
>
> This adds an explicit 'select', like all other hashes have it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-26 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-25 16:51 [PATCH] crypto: hash - select CRYPTO_HASH where needed Arnd Bergmann
2016-01-26 14:48 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®