* [RFC PATCH 02/21] mmc: sdhci-iproc: consolidate parsing path
@ 2016-01-27 5:04 Shawn Lin
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Lin @ 2016-01-27 5:04 UTC (permalink / raw)
To: Ulf Hansson
Cc: bcm-kernel-feedback-list, linux-rpi-kernel, linux-mmc,
linux-kernel, Shawn Lin, Scott Branden
This patch remove mmc_of_parse and check return value
of sdhci_get_of_property.
Cc: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/sdhci-iproc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 3b423b0..18cfe2c 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -196,8 +196,9 @@ static int sdhci_iproc_probe(struct platform_device *pdev)
iproc_host->data = iproc_data;
- mmc_of_parse(host->mmc);
- sdhci_get_of_property(pdev);
+ ret = sdhci_get_of_property(pdev);
+ if (ret)
+ return ret;
/* Enable EMMC 1/8V DDR capable */
host->mmc->caps |= MMC_CAP_1_8V_DDR;
--
2.3.7
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC PATCH 0/21] Totally remove SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk
@ 2016-01-27 5:05 Shawn Lin
2016-01-27 5:06 ` [RFC PATCH 02/21] mmc: sdhci-iproc: consolidate parsing path Shawn Lin
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Lin @ 2016-01-27 5:05 UTC (permalink / raw)
To: Ulf Hansson
Cc: bcm-kernel-feedback-list, linux-rpi-kernel, linux-mmc,
linux-kernel, Shawn Lin
Ulf wants to make sdhci into a library, but it's a huge task
since any improvemts may touch too much platforms. But at least
we should make some effort to push things torwards to this target.
This patchset remove SDHCI_QUIRK_BROKEN_CARD_DETECTION from sdhci
to gradually reduce quirk of sdhci.
Firstly, SDHCI_QUIRK_BROKEN_CARD_DETECTION aims at claiming the slot is
a "broken-cd" one, but "broken-cd" is not a quirk from my view.
In addition, mmc core stack had already obtain "broken-cd" from dts via
mmc_of_parse and pass MMC_CAP_NEEDS_POLL to mmc->caps. So we can reuse it
instead of SDHCI_QUIRK_BROKEN_CARD_DETECTION.
However, before doing the cleanup work, I find that geting _of_ property
for sdhci* is not so pretty good and consistent. Some variant drives use
mmc_of_parse, while another ones use sdhci_get_of_property. I also find some
variant drivers combine these two paths. So in order to make my "broken-cd"
cleanup running, I decide to add mmc_of_parse into sdhci_get_of_property and
replace mmc_of_parse with sdhci_get_of_property for all variant drivers if
needed.
Unfortunately, I don't have all these platforms touched to test my patchset.
I might make some mistakes for these changes, so any comments are welcomed.
Shawn Lin (21):
mmc: sdhci-pltfm: consolidate parsing path
mmc: sdhci-iproc: consolidate parsing path
mmc: sdhci-msm: consolidate parsing path
mmc: sdhci-of-arasan: consolidate parsing path
mmc: sdhci-of-at91: consolidate parsing path
mmc: sdhci-of-esdhc: consolidate parsing path
mmc: sdhci-pxav3: consolidate parsing path
mmc: sdhci-sirf: check sdhci_get_of_property return value
mmc: sdhci_f_sdh30: check sdhci_get_of_property return value
mmc: sdhci: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-acpi: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-bcm-kona: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-bcm2835: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-esdhc-imx: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-msm: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-of-esdhc: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-pci-core: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-pltfm: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-pxav2: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci-s3c: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
mmc: sdhci.h: remove SDHCI_QUIRK_BROKEN_CARD_DETECTION
drivers/mmc/host/sdhci-acpi.c | 3 +--
drivers/mmc/host/sdhci-bcm-kona.c | 3 ---
drivers/mmc/host/sdhci-bcm2835.c | 5 +++--
drivers/mmc/host/sdhci-esdhc-imx.c | 9 +++++----
drivers/mmc/host/sdhci-iproc.c | 5 +++--
drivers/mmc/host/sdhci-msm.c | 6 ++----
drivers/mmc/host/sdhci-of-arasan.c | 11 ++++-------
drivers/mmc/host/sdhci-of-at91.c | 4 +---
drivers/mmc/host/sdhci-of-esdhc.c | 25 ++++++++++++-------------
drivers/mmc/host/sdhci-pci-core.c | 5 ++++-
drivers/mmc/host/sdhci-pltfm.c | 26 +++++++++++++++++++-------
drivers/mmc/host/sdhci-pltfm.h | 2 +-
drivers/mmc/host/sdhci-pxav2.c | 1 -
drivers/mmc/host/sdhci-pxav3.c | 4 +---
drivers/mmc/host/sdhci-s3c.c | 2 +-
drivers/mmc/host/sdhci-sirf.c | 4 +++-
drivers/mmc/host/sdhci.c | 14 +++++---------
drivers/mmc/host/sdhci.h | 30 ++++++++++++++----------------
drivers/mmc/host/sdhci_f_sdh30.c | 5 ++++-
19 files changed, 83 insertions(+), 81 deletions(-)
--
2.3.7
^ permalink raw reply [flat|nested] 2+ messages in thread
* [RFC PATCH 02/21] mmc: sdhci-iproc: consolidate parsing path
2016-01-27 5:05 [RFC PATCH 0/21] Totally remove SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk Shawn Lin
@ 2016-01-27 5:06 ` Shawn Lin
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Lin @ 2016-01-27 5:06 UTC (permalink / raw)
To: Ulf Hansson
Cc: bcm-kernel-feedback-list, linux-rpi-kernel, linux-mmc,
linux-kernel, Shawn Lin, Scott Branden
This patch remove mmc_of_parse and check return value
of sdhci_get_of_property.
Cc: Scott Branden <sbranden@broadcom.com>
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/sdhci-iproc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci-iproc.c b/drivers/mmc/host/sdhci-iproc.c
index 3b423b0..18cfe2c 100644
--- a/drivers/mmc/host/sdhci-iproc.c
+++ b/drivers/mmc/host/sdhci-iproc.c
@@ -196,8 +196,9 @@ static int sdhci_iproc_probe(struct platform_device *pdev)
iproc_host->data = iproc_data;
- mmc_of_parse(host->mmc);
- sdhci_get_of_property(pdev);
+ ret = sdhci_get_of_property(pdev);
+ if (ret)
+ return ret;
/* Enable EMMC 1/8V DDR capable */
host->mmc->caps |= MMC_CAP_1_8V_DDR;
--
2.3.7
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-27 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-27 5:04 [RFC PATCH 02/21] mmc: sdhci-iproc: consolidate parsing path Shawn Lin
2016-01-27 5:05 [RFC PATCH 0/21] Totally remove SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk Shawn Lin
2016-01-27 5:06 ` [RFC PATCH 02/21] mmc: sdhci-iproc: consolidate parsing path Shawn Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®