* Question about create mode, checkpatch, and MAINTAINERS
@ 2016-01-27 17:52 Jeff Merkey
2016-01-27 18:03 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Merkey @ 2016-01-27 17:52 UTC (permalink / raw)
To: LKML; +Cc: Joe Perches
So while putting together a patch series that adds some include files
in the arch/ I ran across the checkpatch WARNING that says MAINTAINERS
needs updating for new files with create mode.
Is the best way to do this to submit MAINTAINERS as a separate patch
or in its own patch with the series, or can I just send the patch
series to the current MAINTAINERS of those arches and skip this add
maintainers and ignore the checkpatch WARNING for this. From what I
have seen, its not a good idea to ignore anything checkpatch reports.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Question about create mode, checkpatch, and MAINTAINERS
2016-01-27 17:52 Question about create mode, checkpatch, and MAINTAINERS Jeff Merkey
@ 2016-01-27 18:03 ` Joe Perches
2016-01-27 18:14 ` Jeff Merkey
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2016-01-27 18:03 UTC (permalink / raw)
To: Jeff Merkey, LKML
On Wed, 2016-01-27 at 10:52 -0700, Jeff Merkey wrote:
> So while putting together a patch series that adds some include files
> in the arch/ I ran across the checkpatch WARNING that says MAINTAINERS
> needs updating for new files with create mode.
> Is the best way to do this to submit MAINTAINERS as a separate patch
> or in its own patch with the series, or can I just send the patch
> series to the current MAINTAINERS of those arches and skip this add
> maintainers and ignore the checkpatch WARNING for this.
You can ignore it.
The checkpatch message is just a prompt. It asks
"does MAINTAINERS need updating"? The checkpatch message
is just asking
to consider whether or not MAINTAINERS
needs updating. MAINTAINERS may
not need updating at all.
> From what I have seen, its not a good idea to ignore anything
> checkpatch reports.
It's always better to ignore mechanized messages from
brainless scripts when you know what you're doing.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Question about create mode, checkpatch, and MAINTAINERS
2016-01-27 18:03 ` Joe Perches
@ 2016-01-27 18:14 ` Jeff Merkey
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Merkey @ 2016-01-27 18:14 UTC (permalink / raw)
To: Joe Perches; +Cc: LKML
On 1/27/16, Joe Perches <joe@perches.com> wrote:
> On Wed, 2016-01-27 at 10:52 -0700, Jeff Merkey wrote:
>> So while putting together a patch series that adds some include files
>> in the arch/ I ran across the checkpatch WARNING that says MAINTAINERS
>> needs updating for new files with create mode.
>> Is the best way to do this to submit MAINTAINERS as a separate patch
>> or in its own patch with the series, or can I just send the patch
>> series to the current MAINTAINERS of those arches and skip this add
>> maintainers and ignore the checkpatch WARNING for this.
>
> You can ignore it.
>
> The checkpatch message is just a prompt. It asks
> "does MAINTAINERS need updating"? The checkpatch message
> is just asking
> to consider whether or not MAINTAINERS
> needs updating. MAINTAINERS may
> not need updating at all.
>
>> From what I have seen, its not a good idea to ignore anything
>> checkpatch reports.
>
> It's always better to ignore mechanized messages from
> brainless scripts when you know what you're doing.
>
>
Thanks Joe.
:-)
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-27 18:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-01-27 17:52 Question about create mode, checkpatch, and MAINTAINERS Jeff Merkey
2016-01-27 18:03 ` Joe Perches
2016-01-27 18:14 ` Jeff Merkey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®