From: Joe Perches <joe@perches.com>
To: Eric Curtin <ericcurtin17@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
Kernel development list <linux-kernel@vger.kernel.org>,
Darren Hart <dvhart@infradead.org>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface"
Date: Wed, 27 Jan 2016 16:43:41 -0800 [thread overview]
Message-ID: <1453941821.10099.33.camel@perches.com> (raw)
In-Reply-To: <CANpvso7UtUrRh6cZT9aNYU7J62ofMMhr7S91Wwa8GWPHc3w1NQ@mail.gmail.com>
On Thu, 2016-01-28 at 00:36 +0000, Eric Curtin wrote:
> On 27 January 2016 at 23:26, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
> > > Message gets logged on machines that are well supported.
[]
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
[]
> > + pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
> > }
> >
> > static int __init brightness_init(struct ibm_init_struct *iibm)
>
> Maybe, but the other logging issues kinda mean something. There are
> many, many reports of people thinking their brightness interface is
> broken because of this logging message, when in reality the i915 driver
> supports their devices just fine as previously stated.
That's why I suggest changing it to show the number
of brightness levels detected on any device.
next prev parent reply other threads:[~2016-01-28 0:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-27 22:14 Eric Curtin
2016-01-27 23:26 ` Joe Perches
2016-01-28 0:36 ` Eric Curtin
2016-01-28 0:43 ` Joe Perches [this message]
2016-01-28 0:52 ` Eric Curtin
2016-01-30 12:20 ` Henrique de Moraes Holschuh
2016-01-30 16:55 ` Eric Curtin
2016-01-30 19:49 ` Henrique de Moraes Holschuh
2016-02-07 20:13 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453941821.10099.33.camel@perches.com \
--to=joe@perches.com \
--cc=dvhart@infradead.org \
--cc=ericcurtin17@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome