From: Jessica Yu <jeyu@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>,
Miroslav Benes <mbenes@suse.cz>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>
Cc: live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
Jessica Yu <jeyu@redhat.com>
Subject: [PATCH 0/2] Fix ordering of ftrace + livepatch module notifier callbacks
Date: Fri, 29 Jan 2016 01:43:45 -0500 [thread overview]
Message-ID: <1454049827-3726-1-git-send-email-jeyu@redhat.com> (raw)
As explained here [1], livepatch modules are failing to initialize properly
because the ftrace coming module notifier (which calls
ftrace_module_enable()) runs after the livepatch module notifier (which
enables the patch(es)). Thus livepatch attempts to apply patches to modules
before ftrace_module_enable() is even called for the corresponding
module(s). Separate klp_module_notify() into coming and going notifiers
and tweak the priorities to fix the order in which the ftrace and livepatch
notifiers are called.
Tested the changes with a test livepatch module that patches 9p and nilfs2,
and verified that the issue is fixed.
Patch 1/2 based on the 'for-next' branch in livepatching -
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/livepatching.git
Patch 2/2 based on the 'ftrace/core' branch in linux-trace -
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
[1] http://lkml.kernel.org/g/20160128204033.GA32131@packer-debian-8-amd64.digitalocean.com
Jessica Yu (2):
livepatch: Implement separate coming and going module notifiers
ftrace: Adjust priority of ftrace module notifier
kernel/livepatch/core.c | 128 +++++++++++++++++++++++++++---------------------
kernel/trace/ftrace.c | 7 ++-
2 files changed, 79 insertions(+), 56 deletions(-)
--
2.4.3
next reply other threads:[~2016-01-29 6:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 6:43 Jessica Yu [this message]
2016-01-29 6:43 ` [PATCH 1/2] livepatch: Implement separate coming and going module notifiers Jessica Yu
2016-01-29 16:30 ` Miroslav Benes
2016-01-29 17:30 ` Josh Poimboeuf
2016-01-29 17:40 ` Steven Rostedt
2016-01-29 17:58 ` Josh Poimboeuf
2016-01-29 19:25 ` Miroslav Benes
2016-01-29 19:29 ` Steven Rostedt
2016-01-29 19:47 ` Josh Poimboeuf
2016-01-29 20:08 ` Steven Rostedt
2016-01-29 20:15 ` Josh Poimboeuf
2016-02-01 12:27 ` Jiri Kosina
2016-02-01 14:48 ` Josh Poimboeuf
2016-01-29 19:51 ` Jessica Yu
2016-01-29 19:42 ` [PATCH 1/2] " Josh Poimboeuf
2016-01-29 22:58 ` Jessica Yu
2016-01-30 0:02 ` Steven Rostedt
2016-02-01 14:37 ` Josh Poimboeuf
2016-01-29 20:04 ` Jessica Yu
2016-01-29 20:09 ` Steven Rostedt
2016-01-29 20:10 ` Steven Rostedt
2016-01-29 20:20 ` Josh Poimboeuf
2016-01-29 6:43 ` [PATCH 2/2] ftrace: Adjust priority of ftrace module notifier Jessica Yu
2016-01-29 14:38 ` Steven Rostedt
2016-01-29 15:45 ` Josh Poimboeuf
2016-01-29 15:49 ` Steven Rostedt
2016-01-29 15:50 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454049827-3726-1-git-send-email-jeyu@redhat.com \
--to=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®